Re: [PATCH v2] treewide: remove CONFIG_DEBUG_INFO from defconfigs

[Masahiro Yamada <yamada.masahiro@socionext.com>]

On Thu, Jun 20, 2019 at 11:30 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> On Thu, Jun 20, 2019 at 10:54:21AM +0200, Sam Ravnborg wrote:
> > Hi Antony
> >
> > On Thu, Jun 20, 2019 at 11:25:09AM +0300, Antony Pavlov wrote:
> > > The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO")
> > > has dropped Kconfig DEBUG_INFO option however we
> > > still have very many DEBUG_INFO mentions in defconfig
> > > files. Drop them using sed:
> > >
> > >   find -iname '*defconfig' -type f -exec \
> > >       sed -i "/CONFIG_DEBUG_INFO=y/d" {} ';'
> > Another approach could be to regenerate all defconfigs.
> > A little scripting around savedefconfig should do it.
> >
> > Then we would get rid of all obsolete symbols in one go - for all
> > defconfigs.
> >
> > The generated defconfig would be the one that people would be using
> > anyway, so there should be only a little risk to introduce new issues
> > doing it this way.
> >
> > Willing to try this approcah - maybe across all architectures?
>
> I once thought the same and came up with this little thing:
>
> #!/bin/bash
>
> for a in arch/*; do
>         arch=$(basename $a)
>         for c in $a/configs/*; do
>                 config=$(basename $c)
>                 export ARCH=$arch
>                 make $config && make savedefconfig && mv defconfig $c
>         done
> done
>
> Just tested, still works. Maybe I should just run this from time to time
> and commit the result. What do you think?


U-Boot does this every release.

Linux does not do this much,
but it depends on the arch maintainer.
(I sometimes saw this re-sync for arm64)

Personally, I do not want to see savedefconfig much.
Even without sorting, "make defconfig" still produces
the same .config file.
It is a boundary of "clean-up" and "just a noise commit".

In summary, it is up to you since you are the maintainer.


-- 
Best Regards
Masahiro Yamada

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox