From: Masahiro Yamada <masahiroy@kernel.org>
To: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] kbuild: add $(always-y) to 'targets'
Date: Mon, 4 May 2020 20:27:43 +0900 [thread overview]
Message-ID: <CAK7LNATNtaynZmZ4bo6AJS4sRvXqmz8KOEiWXDmyxUTFZ+xJPg@mail.gmail.com> (raw)
In-Reply-To: <20200430044252.762041-1-masahiroy@kernel.org>
On Thu, Apr 30, 2020 at 1:43 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> I missed to sync this line in commit 421108c51da4 ("kbuild: rename
> hostprogs-y/always to hostprogs/always-y").
>
> Since then, the files in always(-y) are needlessly rebuilt.
This line is not precise because the files in $(always) are fine.
If it is not too late, could you please reword this line as follows ?
Since then, the files in $(always-y) are needlessly rebuilt.
>
> Fixes: 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 8c28ccb8e..acb0d68b8 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE
> $(call if_changed_dep,as_o_S)
>
> targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y)
> -targets += $(extra-y) $(MAKECMDGOALS) $(always)
> +targets += $(extra-y) $(always-y) $(MAKECMDGOALS)
>
> # Linker scripts preprocessor (.lds.S -> .lds)
> # ---------------------------------------------------------------------------
> --
> 2.25.1
>
--
Best Regards
Masahiro Yamada
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-04 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 4:42 Masahiro Yamada
2020-05-04 6:43 ` Sascha Hauer
2020-05-04 11:27 ` Masahiro Yamada [this message]
2020-05-05 5:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATNtaynZmZ4bo6AJS4sRvXqmz8KOEiWXDmyxUTFZ+xJPg@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox