From: Masahiro Yamada <masahiroy@kernel.org>
To: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] kconfig: add 'option modules' to allow tristate options to become m
Date: Tue, 19 May 2020 03:24:50 +0900 [thread overview]
Message-ID: <CAK7LNAT_L2Wur8iDFpKPD_tCpNPCd4Lk-6epNMJGX2syMurjtw@mail.gmail.com> (raw)
In-Reply-To: <20200518175458.178943-1-masahiroy@kernel.org>
On Tue, May 19, 2020 at 2:55 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Since commit 18895514dc5e ("kconfig: update to v3.18-rc6"), tristate
> symbols cannot become 'm'.
>
> In old days of Linux, CONFIG_MODULES was the special hard-coded in
> Kconfig.
Please reword this paragraph as follows:
In old days of Linux, CONFIG_MODULES was the special option hard-coded
in Kconfig.
>
> The current Kconfig does not know which option is it. You need to
> specify 'option modules' to teach Kconfig that it is the module
> support switch.
>
> Add 'option modules' to revive the module builds.
>
> Fixes: 18895514dc5e ("kconfig: update to v3.18-rc6")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> The module feature has been broken for 8 years,
> and nobody has pointed it out...
>
> common/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 460ac487c..7a99d20bf 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -316,6 +316,7 @@ config MODULES
> depends on HAS_MODULES
> depends on EXPERIMENTAL
> bool "module support"
> + option modules
> help
> This option enables support for loadable modules via insmod. Module
> support is quite experimental at the moment. There is no convenient
> --
> 2.25.1
>
--
Best Regards
Masahiro Yamada
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-18 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 17:54 Masahiro Yamada
2020-05-18 17:54 ` [PATCH 2/2] kbuild: build modules by 'make' Masahiro Yamada
2020-05-18 18:24 ` Masahiro Yamada [this message]
2020-05-20 11:09 ` [PATCH 1/2] kconfig: add 'option modules' to allow tristate options to become m Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAT_L2Wur8iDFpKPD_tCpNPCd4Lk-6epNMJGX2syMurjtw@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox