mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Neeraj Pal <neerajpal09@gmail.com>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [BUG] Stack buffer overflow WRITE of size 1 in nfs_start function
Date: Tue, 11 May 2021 23:36:21 +0530	[thread overview]
Message-ID: <CANi4_RURqfEKZ311qcDQJ+bD9hdoRfrwb3OKMAGzEoKO2Kyk7A@mail.gmail.com> (raw)
In-Reply-To: <20210511085845.GG19819@pengutronix.de>

On Tue, May 11, 2021 at 2:28 PM Sascha Hauer <sha@pengutronix.de> wrote:
> Ok, so my patch doesn't resolve the whole issue. I just tried the nfs
> command once after a long time now and this really seems to be broken
> in other ways as well. I tend to entirely remove the command instead
> of further trying to fix it. The normal way to handle nfs should be
> to use the NFS filesystem implementation anyway which would be
>
> mount -t nfs $server:/path/to/share /foo
>
> I don't think we have the manpower to maintain two NFS implementations,
> so we shouldn't try to.

Ok, so, it resolves the issue in some way but I think not completely
as it seems that after modifying the strdup return value condition, it
later again got crashed, and, it definitely makes sense and I
completely agree with that as we already have one working
implementation of NFS available so no need to maintain or add the
additional code which provides the similar functionality. So, I also
think that it would be better if we remove any unnecessary code so
that will reduce future issues.

Thanks and regards,
Neeraj

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-05-11 18:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17 18:52 Neeraj Pal
2021-05-07  8:41 ` Sascha Hauer
2021-05-10 11:08   ` Neeraj Pal
2021-05-10 13:18     ` Neeraj Pal
2021-05-11  8:58     ` Sascha Hauer
2021-05-11 18:06       ` Neeraj Pal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANi4_RURqfEKZ311qcDQJ+bD9hdoRfrwb3OKMAGzEoKO2Kyk7A@mail.gmail.com \
    --to=neerajpal09@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox