On Fri, Mar 30, 2012 at 10:04 PM, Anand Gadiyar <gadiyar@gmail.com> wrote:

Hi all,

I've just started playing with barebox on OMAP4. I see that with "Release v2011.11.0", my Panda could access the SD card contents, but with the current release it can no longer do so.

Git bisect shows commit 82db23d3f4c1de25bbd4b222a3bd9e81d00414f8 (Use generic block layer to access the drives and do partition parsing) is when it stopped working.

Any pointers?

Thanks in advance,
Anand

Found the problem. I was using a 4GB SD card with just a single FAT32 partition. The pentry.size is reported as 7744449 which fails the check_offset_value() call.
I think this is the same issue Sanjeev reported in February.

Below patch seems to fix the issue for now. But I'm not sure what's the correct way to fix this.

Index: barebox/common/partitions.c
===================================================================
--- barebox.orig/common/partitions.c
+++ barebox/common/partitions.c
@@ -129,8 +129,6 @@ static void __maybe_unused try_dos_parti
                /* do we have to ignore this partition due to limitations? */
                if (check_offset_value(pentry.first_sec) != 0)
                        continue;
-               if (check_offset_value(pentry.size) != 0)
-                       continue;

                if (pentry.first_sec != 0) {
                        pd->parts[pd->used_entries].first_sec = pentry.first_sec;