mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Revert "mtd: nand: make interleaved placement optional"
Date: Wed, 30 Oct 2024 20:50:49 +0300	[thread overview]
Message-ID: <CAP1tNvR_B-Au4k3F2d4s0fqyo-k+bkQh6OOh8LsM6PeJpVaGCg@mail.gmail.com> (raw)
In-Reply-To: <c79699ff-49d9-4cb5-9292-eeb8bdf85702@pengutronix.de>

Hello.

> > This reverts commit d1fe68f1b010b83ddd3559ffbfcb70dca68b2563
> > and ec3b8c646bdc8c2ea0a78923ccb745012eabc097 (as a fixup).
> >
> > The message "CONFIG_NAND_NEED_ECC_PLACEMENT_INTERLEAVED is disabled"
> > is always issued, regardless of the MTD ECC layout used, since it
> > is executed through "fallthrough" from the previous case statement.
> >
> > Additionally, if !IS_ENABLED(CONFIG_NAND_NEED_ECC_PLACEMENT_INTERLEAVED)
> > is triggered, the patch calls break, which disables the additional checks.
...
> These config options were added to control barebox size. We need something
> here, so size conscious users can opt out.

Well, I hope you understood from the description that it was not done
entirely correctly.

Thanks!



  reply	other threads:[~2024-10-30 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 11:54 Alexander Shiyan
2024-10-30 16:22 ` Ahmad Fatoum
2024-10-30 17:50   ` Alexander Shiyan [this message]
2024-10-31  7:51     ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP1tNvR_B-Au4k3F2d4s0fqyo-k+bkQh6OOh8LsM6PeJpVaGCg@mail.gmail.com \
    --to=eagle.alexander923@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox