mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <eagle.alexander923@gmail.com>
To: Barebox List <barebox@lists.infradead.org>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>,
	 Sascha Hauer <s.hauer@pengutronix.de>
Subject: arm psci_probe() bug
Date: Thu, 3 Aug 2023 11:04:36 +0300	[thread overview]
Message-ID: <CAP1tNvRt9ohDy3n3AJ1Fzvvqgbv_0V0iVM1urQWOzN2pT-xgpA@mail.gmail.com> (raw)

Hello.

I found a bug in psci processing.
Currently the kernel writes the following on boot:
psci: probing for conduit method from DT.
psci: invalid "method" property:
...

In the psci_probe() function we do the following:
ret = of_property_read_string(dev->of_node, "method", &method);
and use this (method) variable as an argument for of_psci_fixup().
I suspect we are free this variable at of_property_write_string ->
of_set_property > of_delete_property.

Can you confirm my thought and correct it in the right direction?

Thanks!



             reply	other threads:[~2023-08-03  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  8:04 Alexander Shiyan [this message]
2023-08-03  8:30 ` Sascha Hauer
2023-08-03  8:54   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP1tNvRt9ohDy3n3AJ1Fzvvqgbv_0V0iVM1urQWOzN2pT-xgpA@mail.gmail.com \
    --to=eagle.alexander923@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox