Re: [PATCH 2/4] at91: Use the ddramc driver for all boards whose architecture uses it

[Alexander Shiyan <eagle.alexander923@gmail.com>]

Hello.

> > diff --git a/arch/arm/mach-at91/sama5d3_devices.c b/arch/arm/mach-at91/sama5d3_devices.c
> > index f6d5617e5f..4871c2bd69 100644
> > --- a/arch/arm/mach-at91/sama5d3_devices.c
> > +++ b/arch/arm/mach-at91/sama5d3_devices.c
> > @@ -21,10 +21,9 @@
> >
> >  void at91_add_device_sdram(u32 size)
> >  {
> > -     if (!size)
> > -             size = at91sama5d3_get_ddram_size();
> > -
> > -     arm_add_mem_device("ram0", SAMA5_DDRCS, size);
> > +     add_generic_device("sama5-ddramc", DEVICE_ID_SINGLE, NULL,
> > +                        SAMA5D3_BASE_MPDDRC, SZ_512,
> > +                        IORESOURCE_MEM, NULL);
>
> Is this necessary? I just merged your patch that says that all SAMA5D3
> boards are merged to device tree. The device tree already has a
> "atmel,sama5d3-ddramc" node, so there shouldn't be a need to create the
> device here again.

This series was created before I realized that board files for SAMA5D3 can
be deleted completely. In general, in this case it is a patch race :)

Thanks!