Re: [PATCH v2 1/2] Add support for extlinux.conf

[Alexander Shiyan <eagle.alexander923@gmail.com>]

Hello Ahmad.

...
> > +     if (e->append) {
> > +             char *append;
> > +
> > +             /*
> > +              * The same rootfs image may be launched from eMMC or SD card.
> > +              * Remove any hardcoded root= parameter from "append" to avoid
> > +              * conflicts, then let barebox automatically add the correct
> > +              * root= (via global.bootm.appendroot) based on the boot device.
> > +              */
> > +             if (data.appendroot)
> > +                     append = remove_param(e->append, "ROOT=");
...
> I thus have a question to you: What happens if you drop remove_param()
> completely? Sure we will have two root=, but the later gets precedence,
> so your use case would continue to work without giving users a wrong
> expectation.

Yes, the second one takes priority.
The second one is the one added via extlinux.conf APPEND option.
In our case we need the first parameter, i.e. which comes from barebox
when global.bootm.appendroot is toggled on.

Thanks!