Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases

[Alexander Shiyan <eagle.alexander923@gmail.com>]

ср, 25 мая 2022 г. в 11:16, Ahmad Fatoum <a.fatoum@pengutronix.de>:
> On 25.05.22 08:27, Alexander Shiyan wrote:
> > вт, 24 мая 2022 г. в 15:28, Ahmad Fatoum <a.fatoum@pengutronix.de>:
> >> On 24.05.22 09:30, Alexander Shiyan wrote:
> >>> For the correct work of GPIO driver, we need to define aliases.
> >>> Let's add them to the devicetree.
> > ...
> >>> diff --git a/arch/arm/dts/am335x-myirtech-myd.dts b/arch/arm/dts/am335x-myirtech-myd.dts
> >>> index 6ec65e533d..1ea0f2a440 100644
> >>> --- a/arch/arm/dts/am335x-myirtech-myd.dts
> >>> +++ b/arch/arm/dts/am335x-myirtech-myd.dts
> >>> @@ -6,6 +6,13 @@
> >>>  #include <arm/am335x-myirtech-myd.dts>
> >>
> >> Other boards do #include "am33xx.dtsi", which takes care of these
> >> aliases. It's probably better you include that too.
> >
> > Including this file results in an error.
> >
> > Changed to:
> > #include "am33xx.dtsi"
> > #include <arm/am335x-myirtech-myd.dts>
> >
> > Output:
> > DTC     arch/arm/dts/am335x-myirtech-myd.dtb
> > Error: /home/ARM/barebox/dts/src/arm/am335x-myirtech-myd.dts:6.1-9 syntax error
> > FATAL ERROR: Unable to parse input tree
> >
> > Most likely this is the result of double inclusion of the file arm/am33xx.dtsi,
> > first time from "am33xx.dtsi" and second from arm/am335x-myirtech-myd.dts.
>
> Hi, you need to include if after the upstream DT. That's why it doesn't have
> a /dts-v1/;

Yes, if "am33xx.dtsi" is after <arm/am335x-myirtech-myd.dts>, it compiles fine.
But in this case, upstreaming <arm/am33xx.dtsi> (from local
am33xx.dtsi) overwrites
any binding changes from the board file.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox