From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] remove unnecessary device pointer argument
Date: Thu, 5 Mar 2015 00:24:57 +0800 [thread overview]
Message-ID: <CD9E5BF5-982B-4A7A-AD48-C5B11D7090FD@jcrosoft.com> (raw)
In-Reply-To: <20150304104519.GA11010@pengutronix.de>
> On Mar 4, 2015, at 6:45 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> On Wed, Mar 04, 2015 at 04:43:13PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>
>>> On Mar 4, 2015, at 3:49 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>>>
>>> The struct device_d * argument is not necessary, it can be retrieved from
>>> the FILE *. This adds a convenience function for doing this and removes
>>> the struct device_d * argument from the the filesystem drivers functions.
>>
>> if you do so you should introduce fs_warn/info & co too
>>
>> so we de not use dev_xxx version in fs
>
> We can do that, but it's independent of these patches, right?
I’d said no as we drop the device_d we need drop dev_xxx too
to be logic
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-03-04 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 7:49 [PATCH 1/2] fs: rename inode member of struct filep to priv Sascha Hauer
2015-03-04 7:49 ` [PATCH 2/2] fs: remove unnecessary device pointer argument Sascha Hauer
2015-03-04 8:43 ` [PATCH 2/2] " Jean-Christophe PLAGNIOL-VILLARD
2015-03-04 10:45 ` Sascha Hauer
2015-03-04 16:24 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-03-05 8:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD9E5BF5-982B-4A7A-AD48-C5B11D7090FD@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox