From: "Jules Maselbas" <jmaselbas@zdiv.net>
To: "Ahmad Fatoum" <a.fatoum@pengutronix.de>, <barebox@lists.infradead.org>
Subject: Re: [PATCH] fixup! tee: optee: implement RPMB support
Date: Wed, 26 Mar 2025 10:45:37 +0100 [thread overview]
Message-ID: <D8Q3O7QT2HAC.AQCADSVOMV2U@zdiv.net> (raw)
In-Reply-To: <579eeb04-43ef-4665-99c8-dd9d19cdbb3b@pengutronix.de>
Hi Ahmad,
On Wed Mar 26, 2025 at 7:52 AM CET, Ahmad Fatoum wrote:
> Hello Jules,
>
> On 25.03.25 15:36, Jules Maselbas wrote:
>> Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
>> ---
>> drivers/tee/optee/rpmb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tee/optee/rpmb.c b/drivers/tee/optee/rpmb.c
>> index cdc8afc1a4..ca60f3cf3d 100644
>> --- a/drivers/tee/optee/rpmb.c
>> +++ b/drivers/tee/optee/rpmb.c
>> @@ -5,6 +5,7 @@
>>
>> #define pr_fmt(fmt) "optee-rpmb: " fmt
>>
>> +#include <common.h>
>
> Is this only for ARRAY_SIZE? Then I'd prefer we include <linux/kernel.h> or
Yes, this is for ARRAY_SIZE
> <linux/array_size.h>, because we generally want to cut down on use of
> <common.h>, if only to reduce compile time a bit.
okay
> Also, please send fixups without a reply-to for patches that are already applied.
> This makes it less likely to be missed IMO.
ack
> Cheers,
> Ahmad
>
>
>
>> #include <mci.h>
>>
>> #include "optee_msg.h"
next prev parent reply other threads:[~2025-03-26 9:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 12:16 [PATCH 0/9] Add " Sascha Hauer
2025-03-12 12:16 ` [PATCH 1/9] mci: implement mci_set_blockcount() Sascha Hauer
2025-03-12 12:16 ` [PATCH 2/9] mci: export some functions for RPMB support Sascha Hauer
2025-03-12 12:16 ` [PATCH 3/9] mci: detect RPMB partitions Sascha Hauer
2025-03-12 12:16 ` [PATCH 4/9] mci: add RPMB support Sascha Hauer
2025-03-17 15:18 ` Ahmad Fatoum
2025-03-18 11:33 ` Sascha Hauer
2025-03-19 15:29 ` Sascha Hauer
2025-03-19 15:34 ` Ahmad Fatoum
2025-03-19 15:41 ` Ahmad Fatoum
2025-03-12 12:16 ` [PATCH 5/9] tee: optee: probe successfully even when no devices are found Sascha Hauer
2025-03-12 12:16 ` [PATCH 6/9] tee: optee: implement shared mem alloc/free RPC commands Sascha Hauer
2025-03-18 11:42 ` Ahmad Fatoum
2025-03-12 12:16 ` [PATCH 7/9] tee: optee: implement RPMB support Sascha Hauer
2025-03-25 14:36 ` [PATCH] fixup! " Jules Maselbas
2025-03-26 6:52 ` Ahmad Fatoum
2025-03-26 9:45 ` Jules Maselbas [this message]
2025-03-12 12:16 ` [PATCH 8/9] tee: optee: implement AVB named persistent values support Sascha Hauer
2025-03-12 12:16 ` [PATCH 9/9] commands: add avb_pvalue command Sascha Hauer
2025-03-24 8:25 ` [PATCH 0/9] Add RPMB support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8Q3O7QT2HAC.AQCADSVOMV2U@zdiv.net \
--to=jmaselbas@zdiv.net \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox