* [PATCH 3/7] Zedboard fix compiler warning
@ 2020-04-02 8:19 Michael Graichen
0 siblings, 0 replies; only message in thread
From: Michael Graichen @ 2020-04-02 8:19 UTC (permalink / raw)
To: barebox
Fixes a warning while compiling zynq_mkimage.c
scripts/zynq_mkimage.c:312:2: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
fread returns the number bytes read, if it is not equal to st_size some error has happend
diff --git a/scripts/zynq_mkimage.c b/scripts/zynq_mkimage.c
index 0a1c06947..22bd40b7e 100644
--- a/scripts/zynq_mkimage.c
+++ b/scripts/zynq_mkimage.c
@@ -241,7 +241,7 @@ int main(int argc, char *argv[])
char *buf;
const char *infile = NULL, *outfile = NULL, *cfgfile = NULL;
struct stat st;
- int opt;
+ int opt, ret;
prgname = argv[0];
@@ -309,7 +309,12 @@ int main(int argc, char *argv[])
exit(EXIT_FAILURE);
}
- fread(buf + IMAGE_OFFSET, sizeof(char), st.st_size, ifile);
+ ret = fread(buf + IMAGE_OFFSET, sizeof(char), st.st_size, ifile);
+
+ if(ret != st.st_size) {
+ fprintf(stderr, "Error while reading %s\n", infile);
+ exit(EXIT_FAILURE);
+ }
add_header(buf, st.st_size);
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-02 8:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 8:19 [PATCH 3/7] Zedboard fix compiler warning Michael Graichen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox