mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH] PCM038: Added config option for PCM970 development board
Date: Thu, 26 Apr 2012 11:22:59 +0400	[thread overview]
Message-ID: <E1SNJ2Z-0003rF-35.shc_work-mail-ru@f220.mail.ru> (raw)
In-Reply-To: <20120426071140.GG3852@pengutronix.de>

Thu, 26 Apr 2012 09:11:40 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:

...
> > -/**
> > - * If the PLL settings are in place switch the CPU core frequency to the max. value
> > - */
> > -static int pcm038_power_init(void)
> > -{
> > -	uint32_t spctl0;
> > -
> > -	spctl0 = get_pll_spctl10();
> > -
> > -	/* PLL registers already set to their final values? */
> > -	if (spctl0 == SPCTL0_VAL && MPCTL0 == MPCTL0_VAL) {
> > -		console_flush();
> > -		if (!pmic_power()) {
> > -			/* wait for required power level to run the CPU at 400 MHz */
> > -			udelay(100000);
> > -			CSCR = CSCR_VAL_FINAL;
> > -			PCDR0 = 0x130410c3;
> > -			PCDR1 = 0x09030911;
> > -			/* Clocks have changed. Notify clients */
> > -			clock_notifier_call_chain();
> > -		} else {
> > -			printf("Failed to initialize PMIC. Will continue with low CPU speed\n");
> > -		}
> > -	}
> > -
> > -	/* clock gating enable */
> > -	GPCR = 0x00050f08;
> > -
> > -	return 0;
> > -}
> > -
> > -late_initcall(pcm038_power_init);
> 
> You move pcm038_power_init from a late_initcall to a direct call
> somewhere else. There might be reasons to do this, but such a change
> should not be hidden in a big patch which according to the commit log
> factors out baseboard code. Also I don't see why the function moves
> to another place in this patch.

I make pcm970_init in late_initcall, so we must sure that power & frequency
already initialized before.
OK, I will try to do second version of this patch later.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-04-26  7:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 20:35 Alexander Shiyan
2012-04-26  7:11 ` Sascha Hauer
2012-04-26  7:22   ` Alexander Shiyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1SNJ2Z-0003rF-35.shc_work-mail-ru@f220.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox