From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 03 Aug 2026 23:29:44 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wr0EC-00608B-07 for lore@lore.pengutronix.de; Mon, 03 Aug 2026 23:29:44 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id 68F59200BB4 for ; Mon, 03 Aug 2026 23:29:40 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=t9ilxZf5; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Content-Transfer-Encoding:Content-Type:In-Reply-To:To:Subject:From:Reply-To: MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=6t1SLA0032v/TnK3C5APJpX0f4uVHkt7+pIDKzczISI=; b=t9ilxZf5Obd0NuMdwwd/UQMUFD Matu6/8Wu8GRyIYoCLfuXHXzMMrFFznqV21D8gIN6dz73Q50IVQBP/J5n/g3zzstV5B00fjE3Ec/+ 1mp5xP3lKw0eSUqZmFGOmbi1y4jEop3nwrF520QjJ7s1opKlG3W92qzKA99ihqiJUsgEPoziBbTHI IfegwfWgCiW+1dnMsNXj2aJOG256qatWBuiQBeUKmk8S8M56V5HUNEQWIrn3OHCzgLyXobB66r3DB ai5tBJnihLStMM57QZFa4iM3bL560TOCZZyj6Zd+1oq6CQS/e//L2Z+9ftAY+onlAaQ53loU3hMEe NaqfpfCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wr0CX-00000000Y0i-15pj; Mon, 03 Aug 2026 21:28:01 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wr0CS-00000000Y0J-1tLg for barebox@lists.infradead.org; Mon, 03 Aug 2026 21:27:58 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 705B52002FE; Mon, 03 Aug 2026 23:27:49 +0200 (CEST) Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wr0CL-002l67-1E; Mon, 03 Aug 2026 23:27:49 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wr0CL-00000007wAC-1B67; Mon, 03 Aug 2026 23:27:49 +0200 From: "Sascha Hauer" Subject: Re: [PATCH v3 08/15] usb: ehci: initialize periodic_queue_dma To: "Luca Lauro via B4 Relay" In-Reply-To: <20260802-rn102-rn104-series-v3-8-f7685a279fb5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 03 Aug 2026 21:27:45 +0000 Message-Id: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_142756_733136_AB4936F3 X-CRM114-Status: GOOD ( 18.50 ) X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2026-08-02 15:16, Luca Lauro via B4 Relay wrote: > From: Luca Lauro > > Store the DMA address of the periodic queue head in > ehci->periodic_queue_dma. Without this initiali [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?b3BlbiBsaXN0OkJB?= =?utf-8?b?UkVCT1g=?= , Luca Lauro Sender: "barebox" X-Spamd-Result: default: False [-3.01 / 15.00]; BAYES_HAM(-3.00)[100.00%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; MISSING_MIME_VERSION(2.00)[]; CC_EXCESS_BASE64(1.50)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[2607:7c80:54:3::133:from]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; R_SPF_ALLOW(-0.20)[+mx:c]; MAILLIST(-0.20)[mailman]; RCVD_IN_DNSWL_LOW(-0.10)[2a0a:edc0:0:c01:1d::a2:received]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; FORGED_RECIPIENTS(0.00)[m:devnull+famlauro93l.gmail.com@kernel.org,m:barebox@lists.infradead.org,m:famlauro93l@gmail.com,m:devnull@kernel.org,s:lore@pengutronix.de]; DMARC_NA(0.00)[pengutronix.de]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; RECEIVED_HELO_LOCALHOST(0.00)[]; FROM_HAS_DN(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FORWARDED(0.00)[barebox@lists.infradead.org]; FORGED_SENDER(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; TO_DN_ALL(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; FORGED_SENDER_FORWARDING(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; TAGGED_RCPT(0.00)[famlauro93l.gmail.com]; FORGED_RECIPIENTS_FORWARDING(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_FIVE(0.00)[5]; FREEMAIL_CC(0.00)[lists.infradead.org,gmail.com]; DKIM_TRACE(0.00)[lists.infradead.org:+]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: mx1 X-Rspamd-Queue-Id: 68F59200BB4 X-Stat-Signature: 4pjhso5z5s91e4q6ssdycembty6so394 On 2026-08-02 15:16, Luca Lauro via B4 Relay wrote: > From: Luca Lauro >=20 > Store the DMA address of the periodic queue head in > ehci->periodic_queue_dma. Without this initialization the periodic > schedule may reference an invalid address. >=20 > Signed-off-by: Luca Lauro > --- > drivers/usb/host/ehci-hcd.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 51b9e52a4f..a4832bb3ff 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -897,6 +897,8 @@ static int ehci_init(struct usb_host *host) > periodic->qt_next =3D cpu_to_hc32(QT_NEXT_TERMINATE); > periodic->qt_altnext =3D cpu_to_hc32(QT_NEXT_TERMINATE); > =20 > + ehci->periodic_queue_dma =3D ehci_qh_dma(ehci, periodic); > + > /* > * Step 2: Setup frame-list: Every microframe, USB tries the same list. > * In particular, device specifications on polling frequency > @@ -1442,11 +1444,14 @@ static int ehci_probe(struct device *dev) > if (ret) > return ret; > =20 > - ret =3D clk_bulk_get_all_enabled(dev, &clks); > + ret =3D clk_bulk_get_all(dev, &clks); > if (ret < 0) > return ret; > =20 > num_clocks =3D ret; > + ret =3D clk_bulk_enable(num_clocks, clks); > + if (ret) > + return ret; This looks unrelated to this patch. Does this change make any difference? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |