mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Premi, Sanjeev" <premi@ti.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: RE: [PATCH 0/6] code size reduction for xloader
Date: Thu, 12 Jan 2012 15:14:56 +0000	[thread overview]
Message-ID: <E28AAFD00EFAA646AE3DF9B89CD24A89317F3531@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20120111132914.GB958@game.jcrosoft.org>

> -----Original Message-----
> From: barebox-bounces@lists.infradead.org 
> [mailto:barebox-bounces@lists.infradead.org] On Behalf Of 
> Jean-Christophe PLAGNIOL-VILLARD
> Sent: Wednesday, January 11, 2012 6:59 PM
> To: barebox@lists.infradead.org
> Subject: [PATCH 0/6] code size reduction for xloader
> 
> HI,
> 
> 	this patch serie wrok on disble non needed code to 
> optimize the size
> 	of barebox specially in the case of non interactive 
> version suc as
> 	xloader for TI and late bootstrap for at91
> 
> 	tis will also iclude a sync of the kconfig need for this

I manually pulled all the patches in this series against latest
"master" except (didn't seemed related to size reduction):
      kconfig: sync to linux 3.2-rc4

I encountered compile error in this patch:
    param: add config to disable it

  CC      drivers/mtd/core.o
drivers/mtd/core.c: In function 'add_mtd_device':
drivers/mtd/core.c:230:2: warning: implicit declaration of function 'IS_ENABLED'
drivers/mtd/core.c:230:17: error: 'CONFIG_PARAMETER' undeclared (first use in this function)
drivers/mtd/core.c:230:17: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [drivers/mtd/core.o] Error 1
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2

I am not sure whether IS_ENABLED is implemented in yet-to-be merged patch;
so, continued testing after applying the temp patch at bottom of
this mail.

With the modification, tested all working fine on OMAP3EVM.

I had to apply these patches from the series I posted yesterday,
otherwise, barebox doesn't boot:
   [PATCH 3/5] ARM omap3evm: Allow building first stage
   [PATCH 4/5] ARM omap3evm: Enable HSMMC device

You may add Tested-by: Sanjeev Premi<premi@ti.com> to these:
      banner: add config to disable it
      uncompress: add config to disable it
      filetype: add config to disable it
      driver: switch driver_d name to const char*

~sanjeev

From bbe95b44869d63d991bb26a9098c5f123f3c757e Mon Sep 17 00:00:00 2001
From: Sanjeev Premi <premi@ti.com>
Date: Thu, 12 Jan 2012 20:16:15 +0530
Subject: [PATCH] temp: fix failure due to a portion of prev patch


Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 drivers/mtd/core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
index ccc5c26..dc0d5b0 100644
--- a/drivers/mtd/core.c
+++ b/drivers/mtd/core.c
@@ -227,6 +227,7 @@ int add_mtd_device(struct mtd_info *mtd, char *devname)
        mtd->cdev.dev = &mtd->class_dev;
        mtd->cdev.mtd = mtd;

+#ifdef CONFIG_PARAMETER
        if (IS_ENABLED(CONFIG_PARAMETER)) {
                sprintf(str, "%u", mtd->size);
                dev_add_param_fixed(&mtd->class_dev, "size", str);
@@ -237,7 +238,7 @@ int add_mtd_device(struct mtd_info *mtd, char *devname)
                sprintf(str, "%u", mtd->oobsize);
                dev_add_param_fixed(&mtd->class_dev, "oobsize", str);
        }
-
+#endif
        devfs_create(&mtd->cdev);

        list_for_each_entry(hook, &mtd_register_hooks, hook)

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-01-12 15:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 13:29 Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 13:31 ` [PATCH 1/6] banner: add config to disable it Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 13:31 ` [PATCH 2/6] uncompress: " Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 13:31 ` [PATCH 3/6] filetype: " Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 13:31 ` [PATCH 4/6] kconfig: sync to linux 3.2-rc4 Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 13:31 ` [PATCH 5/6] param: add config to disable it Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 13:31 ` [PATCH 6/6] driver: switch driver_d name to const char* Jean-Christophe PLAGNIOL-VILLARD
2012-01-12  8:50 ` [PATCH 0/6] code size reduction for xloader Sascha Hauer
2012-01-12  9:51   ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-12 15:14 ` Premi, Sanjeev [this message]
2012-01-12 15:21   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E28AAFD00EFAA646AE3DF9B89CD24A89317F3531@DBDE01.ent.ti.com \
    --to=premi@ti.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox