From: "Premi, Sanjeev" <premi@ti.com>
To: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: RE: [PATCH v3] omap: Unify run_shell() in xload configuration
Date: Thu, 27 Oct 2011 14:11:58 +0000 [thread overview]
Message-ID: <E28AAFD00EFAA646AE3DF9B89CD24A89BF50@DBDE01.ent.ti.com> (raw)
In-Reply-To: <1318417430-2039-1-git-send-email-premi@ti.com>
> -----Original Message-----
> From: Premi, Sanjeev
> Sent: Wednesday, October 12, 2011 4:34 PM
> To: barebox@lists.infradead.org
> Cc: Premi, Sanjeev
> Subject: [PATCH v3] omap: Unify run_shell() in xload configuration
>
> Currently, there are multiple definitions of run_shell()
> for each board that can be build in "xload" configuration.
> Now there is only one function used by all boards.
>
> The functions defined in xload.c are used only when "xload"
> configuration used; but it gets compiled unconditionally.
> This has been fixed as well.
>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
>
> Change in v3:
> Added function omap_bootsrc() to replace the #ifdef
> around the switch-case.
>
> Change in v2:
> Fixed the typo in the subject s/iomap/omap/
> ...observed when mail reached my inbox :(
>
> Only build tested with these commands:
> make distclean ; make omap3530_beagle_defconfig ; make ;
> make distclean ; make omap3530_beagle_xload_defconfig ; make ;
> make distclean ; make panda_xload_defconfig ; make ;
> make distclean ; make panda_defconfig ; make ;
> make distclean ; make pcm049_defconfig ; make ;
> make distclean ; make pcm049_xload_defconfig ; make ;
>
>
> arch/arm/boards/omap/board-beagle.c | 31 --------------------------
> arch/arm/boards/panda/board.c | 19 ----------------
> arch/arm/boards/pcm049/board.c | 30 -------------------------
> arch/arm/mach-omap/Makefile | 3 +-
> arch/arm/mach-omap/xload.c | 41
> +++++++++++++++++++++++++++++++++++
> 5 files changed, 43 insertions(+), 81 deletions(-)
>
Jean-Christophe,
Just wanted to check if this patch takes care of your comment[1].
[1] http://lists.infradead.org/pipermail/barebox/2011-October/004752.html
~sanjeev
[snip]...[snip]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-10-27 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 11:03 Sanjeev Premi
2011-10-27 14:11 ` Premi, Sanjeev [this message]
2011-11-10 8:50 ` Premi, Sanjeev
2011-11-10 11:37 ` Sascha Hauer
2011-11-11 10:43 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E28AAFD00EFAA646AE3DF9B89CD24A89BF50@DBDE01.ent.ti.com \
--to=premi@ti.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox