mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michel Stam <michel@reverze.net>
To: Alexander Aring <alex.aring@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/3] x86: Add support for IDE on the legacy I/O ports
Date: Sat, 5 Apr 2014 08:56:25 +0200	[thread overview]
Message-ID: <E97972E6-F8B1-438A-8BEE-F48CF896908F@reverze.net> (raw)
In-Reply-To: <20140405064541.GA658@omega.Speedport_W_921V_1_24_000>


[-- Attachment #1.1: Type: text/plain, Size: 1079 bytes --]

Hello Alex,

I think we misunderstood eachother; I was talking about space changes in .c files caused by an editor. send-email came after the editing. 

Reading back I think you were talking about directly editing patches, which I did not do. 

The patches as they were sent to this list are the immediate result/output of the git send-email command, if theres inconsistencies in the patch file itself I have no explanation for that.

Michel Stam


> On 5 apr. 2014, at 08:45, Alexander Aring <alex.aring@gmail.com> wrote:
> 
> Hi Michel,
> 
>> On Sat, Apr 05, 2014 at 08:39:32AM +0200, Michel Stam wrote:
>> Hello Alex,
>> 
>> Yes, I used send-email. I did notice that my editor changed some tabs to spaces, that is already fixed in my local repository. Ill send it after I tested whether everything still works.
>> 
> you should not do any changes to a patch file except maybe for the
> subject to add "v2" or after the "---" lines. I don't saw any changes to
> that. <stupid_question> Why you did changes with an editor?</stupid_question>
> 
> - Alex

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 6165 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-04-05  6:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25 11:12 Michel Stam
2014-04-05  3:11 ` Jean-Christophe PLAGNIOL-VILLARD
2014-04-05  6:36   ` Michel Stam
2014-04-05  5:01 ` Alexander Aring
2014-04-05  6:39   ` Michel Stam
2014-04-05  6:45     ` Alexander Aring
2014-04-05  6:56       ` Michel Stam [this message]
2014-04-05  6:58         ` Alexander Aring
2014-04-05  7:12           ` Michel Stam
2014-04-05  7:18             ` Alexander Aring
2014-04-05  7:20               ` Michel Stam
2014-04-05  7:21                 ` Alexander Aring
2014-04-04 13:41 [PATCH 1/3] common: Allow for I/O mapped I/O michel
2014-04-04 13:41 ` [PATCH 2/3] x86: Add support for IDE on the legacy I/O ports michel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E97972E6-F8B1-438A-8BEE-F48CF896908F@reverze.net \
    --to=michel@reverze.net \
    --cc=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox