From: John Watts <contact@jookia.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] imx6-mmdc: Revert calibration configuration on failure
Date: Tue, 24 Jan 2023 23:01:47 +1100 [thread overview]
Message-ID: <Y8/IqyxBWfHDdri5@novena-choice-citizen> (raw)
In-Reply-To: <eb9bd043-b6ee-4338-ac56-4f7836cecd04@pengutronix.de>
On Tue, Jan 24, 2023 at 09:29:02AM +0100, Ahmad Fatoum wrote:
> > int mmdc_do_write_level_calibration(void)
> > {
> > + u32 ldectrl[4] = {0};
>
> Initial value never read back.
>
Remove the = {0}?
> > /* check for any errors on both PHYs */
> > - if (wlcalib_failed(P0_IPS) || wlcalib_failed(P1_IPS))
> > + if (wlcalib_failed(P0_IPS) || wlcalib_failed(P1_IPS)) {
> > + pr_debug("Calibration failed, rolling back calibration data\n");
>
> Still you only restore P0 calibration data, even if it succeeded,
> but P1 failed. Is this intended?
Not quite sure what you mean. I restore both P0 and P1 calibration data I
think?
If you're asking whether it is correct behaviour to REVERT all calibration
data, instead of for each channel, I'm not sure. It seems like the safest
thing to do to me since it's unclear why the calibration process has failed.
This is the behaviour U-Boot does and seems to work in the wild.
John.
next prev parent reply other threads:[~2023-01-24 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 20:18 [PATCH 1/2] imx6-mmdc: Work around ERR050070 John Watts
2023-01-23 20:18 ` [PATCH 2/2] imx6-mmdc: Revert calibration configuration on failure John Watts
2023-01-24 8:29 ` Ahmad Fatoum
2023-01-24 12:01 ` John Watts [this message]
2023-01-24 12:07 ` Ahmad Fatoum
2023-01-24 8:27 ` [PATCH 1/2] imx6-mmdc: Work around ERR050070 Ahmad Fatoum
2023-01-24 11:48 ` John Watts
2023-01-24 11:58 ` Ahmad Fatoum
2023-01-24 17:41 ` [PATCH v2 " John Watts
2023-01-25 15:48 ` Sascha Hauer
2023-01-24 17:41 ` [PATCH v2 2/2] imx6-mmdc: Revert calibration configuration on failure John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8/IqyxBWfHDdri5@novena-choice-citizen \
--to=contact@jookia.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox