From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jules Maselbas <jmaselbas@zdiv.net>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH] fbconsole: add missing break
Date: Thu, 27 Mar 2025 09:12:51 +0100 [thread overview]
Message-ID: <Z-UIgzNKC7RWo88j@pengutronix.de> (raw)
In-Reply-To: <20250325160008.1076-1-jmaselbas@zdiv.net>
On Tue, Mar 25, 2025 at 05:00:08PM +0100, Jules Maselbas wrote:
> The cursor move CSI has nothing to do with the clear-screen CSI.
CSI n K is erase to beginning or end of line.
> The existing fallthrough looks like a bug, add the missing break.
>
> Fixes: 27f79c05ab ("video: implement framebuffer console")
> Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
> ---
>
> I am not 100% sure if this is a bug or not, it feels like it sould not
> fallthrough, an extra look would be nice.
Yes, really looks like a bug. Moving the cursor shouldn't erase
anything.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-03-27 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 16:00 Jules Maselbas
2025-03-27 7:56 ` Sascha Hauer
2025-03-27 8:12 ` Sascha Hauer [this message]
2025-03-27 8:17 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-UIgzNKC7RWo88j@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@zdiv.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox