From: Konstantin Kletschke <konstantin.kletschke@inside-m2m.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: beaglebone: add delay in lowlevel.c
Date: Wed, 8 Jan 2025 16:14:45 +0100 [thread overview]
Message-ID: <Z36WZYxab1bAEzFG@hephaistos> (raw)
In-Reply-To: <Z36MZJtzptPAdmsI@pengutronix.de>
Hello Sascha,
On Wed, Jan 08, 2025 at 03:32:04PM +0100, Sascha Hauer wrote:
> Calling udelay(1000) and adding a comment saying it delays 1.8ms looks
> inconsistent. Maybe better count up to 2 in __udelay() above which makes
I completely agree somehow since the time is not even constant and depends on
the PLL settings just done before.
I suggest the following:
Removing the "* 3" fancy thingy in the function's loop, calling the
function with 3000 instead of 1000, changing comment to "needed on some
Beaglebone Black for warm start after reset".
That would be as simple as possible.
Regards
Konsti
--
INSIDE M2M GmbH
Konstantin Kletschke
Berenbosteler Straße 76 B
30823 Garbsen
Telefon: +49 (0) 5137 90950136
Mobil: +49 (0) 151 15256238
Fax: +49 (0) 5137 9095010
konstantin.kletschke@inside-m2m.de
http://www.inside-m2m.de
Geschäftsführung: Michael Emmert, Derek Uhlig
HRB: 111204, AG Hannover
next prev parent reply other threads:[~2025-01-08 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 15:01 Konstantin Kletschke
2025-01-08 14:32 ` Sascha Hauer
2025-01-08 15:14 ` Konstantin Kletschke [this message]
2025-01-08 15:19 ` Ahmad Fatoum
2025-01-08 15:27 ` Konstantin Kletschke
2025-01-08 15:31 ` Ahmad Fatoum
2025-01-08 15:38 ` Konstantin Kletschke
2025-01-08 15:46 ` Lucas Stach
2025-01-08 15:18 Konstantin Kletschke
2025-01-08 15:36 Konstantin Kletschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z36WZYxab1bAEzFG@hephaistos \
--to=konstantin.kletschke@inside-m2m.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox