Re: [PATCH 0/2] Move pca9450 RESET_CTRL configuration to driver

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Mar 11, 2025 at 12:40:03PM +0100, Jonas Rebmann wrote:
> Hi Rouven,
> 
> On 2025-03-11 12:05, Rouven Czerwinski wrote:
> > Does it make sense to select the pcs9450 in the board kconfig symbols?
> > This way users retain the behaviour after an update even if the pca9450
> > driver was not selected before.
> 
> Are you referring to a scenario where removal of an explicit initialization
> of PCA9450_RESET_CTRL in favor of the setup in the driver would lead to an
> unitialized PCA9450_RESET_CTRL if the driver is not enabled?
> 
> For the imx93 boards, behaviour remains unchanged same as those two boards
> configure PCA9450_RESET_CTRL in pca9450_register_init_callback, which is
> called by the driver. So change in behavior with those.
> 
> Not so on the imx8 boards where pmic_configure is called unconditionally in
> the power-on routine.
> 
> Given this, I'm not sure if we should remove the explicit register config
> for the imx8 boards as Ahmad mentioned. I think I remember Sasha mentioning
> a reason why board kconfig doesn't select the pmic driver?..

Yes. We can't select the PMIC driver from the board Kconfig because we
would also have to select all direct dependencies like I2C. Although not
a direct dependency we would also have to select the I2C hardware bus
driver, because without it we also could not access the PMIC. All this
is cumbersome to do, so better avoided. If necessary we could issue a
warning message at runtime and leave it up to the user to select the
missing pieces.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |