Re: [PATCH 1/2] mfd: pca9450: configure pmic reset behavior

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Mar 11, 2025 at 11:50:17AM +0100, Jonas Rebmann wrote:
> Currently, boards using the pca9450 pmic driver initialize the
> RESET_CTRL register either in lowlevel.c or board.c explicitly to 0xA1
> to enable the watchdog for Cold Reset with all voltage regulators
> recycled except LDO1/ LDO2 in addition to the default configuration of
> 0x11 where the WDOG_B watchdog input is disabled.
> 
> Instead, enable the watchdog in the driver for Cold Reset with all
> voltage regulators recycled except LDO1/ LDO2. When
> nxp,wdog_b-warm-reset is set, the watchdog is instead enabled for Warm
> Reset.
> 
> This is identical to U-Boot's behaviour since commit 910c7a881f5 and
> Linux's since commit 2364a64d0673f.

Please add the commit description like

910c7a881f5 ("pmic: pca9450: Make warm reset on WDOG_B assertion") and
2364a64d0673f ("regulator: pca9450: Make warm reset on WDOG_B assertion")

> 
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
> ---
>  drivers/mfd/pca9450.c | 11 +++++++++++
>  include/mfd/pca9450.h |  4 ++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/mfd/pca9450.c b/drivers/mfd/pca9450.c
> index 2511e662c3dfb5dfedbc461357ffa82d1812166f..6d6fb32c36569689b901455b3376c92977eabc37 100644
> --- a/drivers/mfd/pca9450.c
> +++ b/drivers/mfd/pca9450.c
> @@ -3,6 +3,7 @@
>   * Copyright (C) 2023 Holger Assmann, Pengutronix
>   */
>  
> +#include "linux/regmap.h"

Please include files from the include paths with <> rather than "".

In this case you can drop it entirely, because linux/regmap.h is already
included by regmap.h

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |