From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: qemu: mask data aborts during AMBA identification
Date: Tue, 18 Mar 2025 12:07:07 +0100 [thread overview]
Message-ID: <Z9lT26AVZGa65OWT@pengutronix.de> (raw)
In-Reply-To: <20250318082507.419785-4-a.fatoum@pengutronix.de>
On Tue, Mar 18, 2025 at 09:25:07AM +0100, Ahmad Fatoum wrote:
> The barebox FIT image target is meant as an easy way to load barebox
> second stage from other bootloaders.
>
> Doing so with U-Boot 2025.01 compiled for qemu_arm64_defconfig
> currently leads to a crash when accessing the PL061 GPIO controller
> device for identification.
>
> It seems that U-Boot (or TF-A, which wasn't included in my setup)
> should have done some initial setup to allow access to the PL061.
>
> barebox doesn't even have a driver for the peripheral and loading
> barebox directly with -kernel works. In both cases, barebox runs in EL1.
>
> Let's thus workaround the issue on the barebox side by using the new
> CONFIG_ARM_AMBA_DABT_MASK option to turn the crash into an error
> message.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f5f9f3828782..7d46dcfb63dc 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -282,6 +282,7 @@ config BOARD_ARM_VIRT
> select BOARD_GENERIC_DT
> select BOARD_QEMU_VIRT
> select OF_OVERLAY
> + select ARM_AMBA_DABT_MASK
Ah, ok. You select the option where you anticipate that it's useful.
Should have read this patch before commenting on #3.
Fine with me then.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-03-18 11:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 8:25 [PATCH 1/4] scripts/make_fit: factor dtb file name into configuration name Ahmad Fatoum
2025-03-18 8:25 ` [PATCH 2/4] amba: drop unused hepers for creating AMBA devices outside OF Ahmad Fatoum
2025-03-18 10:53 ` Uwe Kleine-König
2025-03-18 8:25 ` [PATCH 3/4] amba: support masking data abort during identification Ahmad Fatoum
2025-03-18 11:04 ` Sascha Hauer
2025-03-18 11:24 ` Ahmad Fatoum
2025-03-18 8:25 ` [PATCH 4/4] ARM: qemu: mask data aborts during AMBA identification Ahmad Fatoum
2025-03-18 11:07 ` Sascha Hauer [this message]
2025-03-18 11:03 ` [PATCH 1/4] scripts/make_fit: factor dtb file name into configuration name Uwe Kleine-König
2025-03-18 11:27 ` Ahmad Fatoum
2025-03-18 11:33 ` Uwe Kleine-König
2025-03-18 11:07 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9lT26AVZGa65OWT@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox