From: Jules Maselbas <jmaselbas@zdiv.net>
To: marc@cpdesign.com.au
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/3] commands: add pwm manipulation command
Date: Mon, 29 May 2023 14:18:26 +0200 [thread overview]
Message-ID: <ZHSYEhkuMVhPJvSS@tour> (raw)
In-Reply-To: <8267577.NyiUUSuA9g@dev8>
On Mon, May 29, 2023 at 09:03:52PM +1000, marc@cpdesign.com.au wrote:
> Hi,
>
> Thanks for your comments. ..
>
...
> > > + error = pwm_apply_state(pwm, &state);
> > > +
> > > + if (stop > 0) {
> > > + state.p_enable = false;
> > > + error = pwm_apply_state(pwm, &state);
> > > + }
> > > +
> > > + pwm_free(pwm);
> > > +
> > > + return error;
> >
> > nit: return 0
> >
>
> This I didn't change - error is propagating return value of pwm_apply_state()
Oh, you're right, sorry
>
> I also fixed your other comments for pwm_get (including the somewhat
> embarrassing ^S :/ )
>
> Cheers
> Marc
>
>
>
next prev parent reply other threads:[~2023-05-29 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 0:13 Adding PWM Commands Marc Reilly
2023-05-29 0:13 ` [PATCH v2 1/3] commands: add pwm manipulation command Marc Reilly
2023-05-29 9:23 ` Jules Maselbas
2023-05-29 11:03 ` marc
2023-05-29 12:18 ` Jules Maselbas [this message]
2023-05-29 0:13 ` [PATCH v2 2/3] commands: pwm: add pwm_get command Marc Reilly
2023-05-29 9:06 ` Jules Maselbas
2023-05-29 0:13 ` [PATCH v2 3/3] include: pwm: minor function doc fix for pwm_set_relative_duty_cycle() Marc Reilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHSYEhkuMVhPJvSS@tour \
--to=jmaselbas@zdiv.net \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox