From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 03 Jan 2024 19:59:38 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rL6Sp-002Qa0-0g for lore@lore.pengutronix.de; Wed, 03 Jan 2024 19:59:38 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rL6So-0006hs-4t for lore@pengutronix.de; Wed, 03 Jan 2024 19:59:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4bZHHe35XC/f2XrC3sJKL4L4QkwX6i7sk9Hp6bhheSY=; b=Oc9sisNHnvAfvnz39AWP5mdWuP bR3kZtNhUwd1JOMfZWLEd9W3xurF2CU+eDQBmO8LXhVda6VZk9f8iKPlPC7RdEAnNvF5BcG0yolPT KP9fjDd2EIZVxOEDG5rRkk36BLZLuatZSzYMZagdl0Lz4K6i6/BBosUTECHiy+9cE1Vs8bsFM+J3G bTxw9UwypRziIaN4VevAzF0TR3s8iheDHc8YPWvTotWULJ+WC/JuHVL2JL+dOsXLQeEG3LkGDv846 qyPHdxi5lep7TkxEUYByAjTLDpTBQ4duM6yRbuBRT4n4PllwxRI1WBbL289GF5RXm22fUv55PtOdW U0ocpPFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rL6Rh-00BqzX-1G; Wed, 03 Jan 2024 18:58:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rL6Rd-00Bqyh-1h for barebox@lists.infradead.org; Wed, 03 Jan 2024 18:58:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rL6Ra-0006M7-N9; Wed, 03 Jan 2024 19:58:22 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rL6Ra-000B3y-Al; Wed, 03 Jan 2024 19:58:22 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rL6Ra-00HHg0-0q; Wed, 03 Jan 2024 19:58:22 +0100 Date: Wed, 3 Jan 2024 19:58:22 +0100 From: Michael Olbrich To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: Mail-Followup-To: Ahmad Fatoum , barebox@lists.infradead.org References: <20240103181312.409668-1-a.fatoum@pengutronix.de> <20240103181312.409668-60-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103181312.409668-60-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240103_105825_588800_2FCE68C2 X-CRM114-Status: GOOD ( 26.19 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 059/112] efi: payload: init: restrict barebox mem to first 1G only on x86 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Wed, Jan 03, 2024 at 07:12:19PM +0100, Ahmad Fatoum wrote: > When run as EFI payload, barebox will not have full access to DRAM and will > have to ask the EFI firmware for memory. It does so once at the beginning > and since commit 356aaef5a37d ("efi: improve malloc pool allocation"), > the buffer was always placed beneath the 1G boundary. > > Aforementioned commit didn't elaborate why a maximum of 1G in particular > was chosen. Anyways, non-PC architectures have different memory maps, so > a 1G limit doesn't make sense there. Therefore restrict the limit to > ARCH_X86. On non-x86, we allow the memory pages to be located anywhere. The 1G is somewhat arbitrary but if you don't restrict the memory to 32bit, then loading the kernel may fail: The addresses in "struct linux_kernel_header" are only 32bit. So if you impose no restrictions at all, then this memory cannot be used for the kernel and initrd. Regards, Michael > This can break PCI drivers on systems that so far assumed barebox memory > is located in the first 4G, but that's ok. That code will need to be > fixed eventually anyway. > > Cc: Michael Olbrich > Signed-off-by: Ahmad Fatoum > --- > efi/payload/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/efi/payload/init.c b/efi/payload/init.c > index 4b612e61afb3..0c2f38e9c86a 100644 > --- a/efi/payload/init.c > +++ b/efi/payload/init.c > @@ -292,7 +292,7 @@ void efi_main(efi_handle_t image, struct efi_system_table *sys_table) > BS->handle_protocol(efi_loaded_image->device_handle, > &efi_device_path_protocol_guid, (void **)&efi_device_path); > > - mem = 0x3fffffff; > + mem = IS_ENABLED(CONFIG_X86) ? 0x3fffffff : ~0ULL; > for (memsize = SZ_256M; memsize >= SZ_8M; memsize /= 2) { > efiret = BS->allocate_pages(EFI_ALLOCATE_MAX_ADDRESS, > EFI_LOADER_DATA, > -- > 2.39.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |