From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: mci-core: Compile fix
Date: Tue, 8 Apr 2025 09:50:03 +0200 [thread overview]
Message-ID: <Z_TVK5M8QOBcv424@pengutronix.de> (raw)
In-Reply-To: <20250408070339.53470-1-eagle.alexander923@gmail.com>
On Tue, Apr 08, 2025 at 10:03:39AM +0300, Alexander Shiyan wrote:
> Fix compilation error:
> drivers/mci/mci-core.c: In function 'mci_part_add':
> drivers/mci/mci-core.c:693:32: error: invalid storage class for function 'mmc_extract_gpp_units'
> 693 | static __maybe_unused unsigned mmc_extract_gpp_units(const char *ecsd_info, unsigned idx)
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/mci/mci-core.c:693:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> 693 | static __maybe_unused unsigned mmc_extract_gpp_units(const char *ecsd_info, unsigned idx)
> ...
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> drivers/mci/mci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index 76d679ed2e..2c82379b0d 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -676,7 +676,7 @@ static void mci_part_add(struct mci *mci, uint64_t size,
>
> if (area_type == MMC_BLK_DATA_AREA_RPMB)
> mci->rpmb_part = part;
> - else if (area_type == MMC_BLK_DATA_AREA_MAIN) {
> + else if (area_type == MMC_BLK_DATA_AREA_MAIN)
That was a mismerge on the -next branch. I just fixed it up, thanks for
noting.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2025-04-08 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 7:03 Alexander Shiyan
2025-04-08 7:50 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_TVK5M8QOBcv424@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox