From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] regulator: Add Fairchild FAN53555 driver
Date: Mon, 1 Jul 2024 15:08:44 +0200 [thread overview]
Message-ID: <ZoKqXLNa1l60t2Yr@pengutronix.de> (raw)
In-Reply-To: <20240621051806.5660-1-eagle.alexander923@gmail.com>
On Fri, Jun 21, 2024 at 08:18:06AM +0300, Alexander Shiyan wrote:
> This driver supports Fairchild FAN53555 Digitally Programmable TinyBuck Regulator.
>
> Supported ICs:
> fan53526, fan53555, rk8600, rk8602, syr827, syr828, tcs4525, tcs4526.
>
> The driver is written based on the fan53555.c linux kernel driver.
> Widely used in new developments based on Rockchip SOCs RK35xx.
>
> + ret = of_property_read_u32(np, "fcs,suspend-voltage-selector", &val);
> + if (!ret) {
> + if (val >> 1) {
Although is funcionally the same you likely wanted to write val > 1
here. Replaced this with the easier to read version ;)
Sascha
> + dev_err(di->dev, "Invalid VSEL ID=%u!\n", val);
> + ret = -EINVAL;
> + goto err;
> + }
> +
> + di->sleep_vsel_id = val;
> + }
> +
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2024-07-01 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 5:18 Alexander Shiyan
2024-07-01 13:03 ` Sascha Hauer
2024-07-01 13:08 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoKqXLNa1l60t2Yr@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox