Re: [PATCH 2/9] ARM: Layerscape: TQMLS1046a: add support for 8GiB variant

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Oct 21, 2024 at 11:06:47AM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 21.10.24 09:21, Sascha Hauer wrote:
> > The tqmls1046a also has a 8GiB DDR variant. This patch adds support for
> > this variant as an additional image with suffix _8g in the name.
> > 
> > The 8GiB boards use two different types of DDR chips which can be
> > distinguished by reading the EEPROM. There is one regular version which
> > has the string "TQMLS1046A-P2.0201" is the EEPROM. The other one is
> > possibly only used for Arkona and has the string "TQMLS1046A-CA.0202"
> > in the EEPROM. There might be other possible strings we are currently
> > not aware of, we fall back to the P2 variant in this case.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> 
> [snip]
> 
> > -static int tqmls1046a_mem_init(void)
> > +static void ls1046a_add_memory(void)
> >  {
> > +	u32 cs0_bnds;
> > +	unsigned long long memsize, lower, upper;
> 
> Nitpick: u64
> 
> > +ENTRY_PROC(start_tqmls1046a_8g)
> > +	mov x3, #STACK_TOP
> > +	mov sp, x3
> > +	b tqmls1046a_8g_entry
> 
> We should be able to migrate these assembly entry points to
> use ENTRY_FUNCTION_WITHSTACK.

We could do here. A few patches further down though when adding TF-A
support the stack address will depend on the exception level which can't
be covered by ENTRY_FUNCTION_WITHSTACK.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |