From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Jonas Rebmann <jre@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH] automount: add nfs section to board automount scripts
Date: Tue, 22 Oct 2024 10:20:21 +0200 [thread overview]
Message-ID: <ZxdgRW6eDs0TYCnP@pengutronix.de> (raw)
In-Reply-To: <b1699907-4424-4da5-bcbc-eed660f8d031@pengutronix.de>
On Tue, Oct 22, 2024 at 08:23:43AM +0200, Ahmad Fatoum wrote:
> Hello Jonas,
>
> Thanks for your patch.
>
> On 21.10.24 17:22, Jonas Rebmann wrote:
> > When nfs automount was introduced in b31b7cf7e8b6, board specific
>
> Nitpick: Kernel convention is to format commit hashes as
> commit b31b7cf7e8b6 ("defaultenv-2: add automount for nfs").
>
> > automount scripts where not updated
>
> Nitpick: missing full stop.
>
> >
> > ---
> > Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
>
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> Note that this will be cut off by git am, because it's under the ---.
Fixed up while applying.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-10-22 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 15:22 Jonas Rebmann
2024-10-22 6:23 ` Ahmad Fatoum
2024-10-22 8:20 ` Sascha Hauer [this message]
2024-10-22 8:19 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxdgRW6eDs0TYCnP@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jre@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox