From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 13 Jun 2023 13:44:25 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q92Rn-005912-8X for lore@lore.pengutronix.de; Tue, 13 Jun 2023 13:44:25 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q92Rl-0006eO-1H for lore@pengutronix.de; Tue, 13 Jun 2023 13:44:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xo1ypW6qkaxhit4Yg9LM9fZUHRCEgOwBrW4JlkSPxgI=; b=hAxe5IQTgQjR8B9eF2Tl5BX1zg W/Wi5X7+JIIhKv5DlwCAveg1DsFPqtL183Df5rDdlLFDr4k3ygMotwCry2OAKTExxLFVay6O70oid 6V0ZbY4aFsxdiTfFSSfzPSsh2I5h9lBWYL0nQbOkSrhP1F/cSCqrOpES+iqzYXSPK9MxtICg358tP hwi/8LbmJvwC+WMoGU4Tbc0XGbHVKrCg+UF3SRNMgrh8EmizfuUVCz51gddeADB7yrXaD537yyrXf Kdw1iA2n5ZT8JjP/geBH4hs+la2tODIpe8z8uqe46TICWHXvWoQgqXyGhUtX/5M8SkOvVtLkhEE9+ wv38RlNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q92QN-007wd1-1x; Tue, 13 Jun 2023 11:42:59 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q92QJ-007wcP-0d for barebox@lists.infradead.org; Tue, 13 Jun 2023 11:42:58 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q92QH-0006Xi-9u for barebox@lists.infradead.org; Tue, 13 Jun 2023 13:42:53 +0200 Message-ID: Date: Tue, 13 Jun 2023 13:42:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US, de-DE To: barebox@lists.infradead.org References: <044fee32-5560-2e85-a0d3-cc7cea71ed48@pengutronix.de> From: Johannes Zink In-Reply-To: <044fee32-5560-2e85-a0d3-cc7cea71ed48@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_044255_257635_308DF428 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [Bug] Nullpointer Exception in of_diff X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hi Ahmad, On 6/12/23 16:50, Ahmad Fatoum wrote: > Hello Johannes, > > On 12.06.23 16:26, Johannes Zink wrote: >> Hi, >> >> I observed a Nullpointer Exception in barebox barebox 2023.05.0 on a Rock3a when calling >> >> of_diff . . > > This should be already fixed in next. You can ask Sascha to pick > "commands: of_diff: simplify error handling" to master if that > fixes your issue. thanks for your reply, it is fixed in next indeed. I just gave it a quick test run. @Sascha: as this fixes a Nullpointer dereference, maybe Ahmad's patch is a candidate to pick into master? > > [snip] > > You can pipe barebox crash logs into Linux scripts/decode_stacktrace.sh > to get line numbers (don't forget to set ARCH/CROSS_COMPILE). > Enabling CONFIG_KASAN=y can also be very useful to pinpoint the origin > of memory corruptions. > That's good to know, thank you. This will definitely help me the next time. Johannes > Cheers, > Ahmad > >> >> Best regards >> Johannes >> >> > -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |