From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Jonas Rebmann <jre@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/2] Move pca9450 RESET_CTRL configuration to driver
Date: Tue, 11 Mar 2025 12:05:22 +0100 [thread overview]
Message-ID: <a2b2fd98bb4d5f5597b55587ddc9f6b6e4da8fcb.camel@pengutronix.de> (raw)
In-Reply-To: <20250311-pca9450-wdog-v1-0-45120abeae00@pengutronix.de>
Hi,
On Tue, 2025-03-11 at 11:50 +0100, Jonas Rebmann wrote:
> Configure the RESET_CTRL register of the pca9450 pmic in the driver,
> like u-boot and kernel do. Subsequently, remove the setup of this
> register from the pca9450_register_init_callback of the two imx93 boards
> we currently have.
Does it make sense to select the pcs9450 in the board kconfig symbols?
This way users retain the behaviour after an update even if the pca9450
driver was not selected before.
> Configuration of this register in lowlevel.c of the imx8 boards remains
> untouched for now as they use a larger array of pmic register setups
> which I haven't given a closer look as to which is actually needed given
> the defaults and what's done in the driver already.
>
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
> ---
> Jonas Rebmann (2):
> mfd: pca9450: configure pmic reset behavior
> ARM: boards: remove obsolete PCA9450_RESET_CTRL setup
>
> arch/arm/boards/phytec-phycore-imx93/board.c | 9 ---------
> arch/arm/boards/tqma93xx/board.c | 3 ---
> drivers/mfd/pca9450.c | 11 +++++++++++
> include/mfd/pca9450.h | 4 ++++
> 4 files changed, 15 insertions(+), 12 deletions(-)
> ---
> base-commit: d004da6e3710cc01b645a57c8dd1a986eced1c80
> change-id: 20250311-pca9450-wdog-b9458f1a26ff
>
> Best regards,
Best regards,
Rouven
next prev parent reply other threads:[~2025-03-11 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:50 Jonas Rebmann
2025-03-11 10:50 ` [PATCH 1/2] mfd: pca9450: configure pmic reset behavior Jonas Rebmann
2025-03-12 12:38 ` Sascha Hauer
2025-03-11 10:50 ` [PATCH 2/2] ARM: boards: remove obsolete PCA9450_RESET_CTRL setup Jonas Rebmann
2025-03-11 11:03 ` Ahmad Fatoum
2025-03-11 11:21 ` Jonas Rebmann
2025-03-11 11:42 ` Ahmad Fatoum
2025-03-12 12:43 ` Sascha Hauer
2025-03-11 11:05 ` Rouven Czerwinski [this message]
2025-03-11 11:40 ` [PATCH 0/2] Move pca9450 RESET_CTRL configuration to driver Jonas Rebmann
2025-03-11 11:42 ` Jonas Rebmann
2025-03-12 12:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b2fd98bb4d5f5597b55587ddc9f6b6e4da8fcb.camel@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jre@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox