From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 11 Apr 2023 12:01:37 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pmAoi-00HRDe-LL for lore@lore.pengutronix.de; Tue, 11 Apr 2023 12:01:37 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmAoi-0002xb-GI for lore@pengutronix.de; Tue, 11 Apr 2023 12:01:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:Cc:References:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z6rB5Tmj3JfX3fbRwGLtDVTnSPLQ8kVSFboyGjETtiE=; b=O4jDFDKhzfDyTVmXnaT4buBCup RMeGVJXK8llPzVp2869KaU+dgsonvbNFZcgs7SLY5Dsmr8wSrwz66xvntUhN9w/mHCoT2xJGQ9ty2 vf3xrcodcXDWZfHsPcrcwxAjGN02HiAx1swXoOHYeWjzxPpj7f0pNnhDoJUbTG89b7I52dhCyRPdD SNu1EFL8eiIsWGkVSd+3Kp/ELpM2OTW72h3PlNbCwHQV3lhYm1inJTqKqTg4FUJZ6P4EKP9MWdShO /JDKGTCLU+Kzwkt/mHIgZQfxvrz6N88ArkbGpIYEqnf1Byv1hLkUanCuLD/OobD5NEFyIMleorz25 EEirorGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmAnb-00HAaS-3D; Tue, 11 Apr 2023 10:00:28 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmAnW-00HAZG-2k for barebox@lists.infradead.org; Tue, 11 Apr 2023 10:00:24 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pmAnS-0002V8-V9; Tue, 11 Apr 2023 12:00:19 +0200 Message-ID: Date: Tue, 11 Apr 2023 12:00:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US From: Ahmad Fatoum To: Sascha Hauer References: <20230313144220.1689252-1-a.fatoum@pengutronix.de> Cc: "barebox@lists.infradead.org" In-Reply-To: <20230313144220.1689252-1-a.fatoum@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_030022_891429_048F3180 X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v3 0/3] boards: qemu-virt: support passing in FIT public key X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hello Sascha, please drop a9d3244883d7 ("boards: qemu-virt: apply overlay at postcore_initcall level") e664ca8f7c35 ("boards: qemu-virt: compile overlay as such") 224b5ef1da4c ("boards: qemu-virt: support passing in FIT public key") again. I had been testing with ARM qemu_virt64_defconfig, but now that I tested on RISC-V, I notice that non-qemu-virt platforms also execute the initcall when they shouldn't and that DTC_CPP_FLAGS wasn't defined for overlays leading to broken state there. I'll send a revised version, but please drop the current one for now. Thanks, Ahmad On 13.03.23 15:42, Ahmad Fatoum wrote: > FIT public key is usually passed in via board DT. Usual way to use > barebox with QEMU Virt however is to use DT supplied by Qemu and apply > overlay to it. mkimage doesn't generate overlay DTB though. To make > barbebox Qemu Virt behave like other boards, let's define a dummy DT > that includes CONFIG_BOOTM_FITIMAGE_PUBKEY, which is merged with the > barebox live device tree. > > This replaces v2 of the series available in next and fixes the > regressions I introduced for deep-probe systems that ensure probe in > other devices. > > I dropped Jan's Tested-by, because the differences warrant it, but > I tested locally that a RSA key was registered as before. > > v2 was here: > https://lore.barebox.org/barebox/20230210165353.3601175-1-a.fatoum@pengutronix.de/ > > v2 -> v3: > - drop "support of_ensure_probed for top-level machine device" > - switch from board driver back to initcall > > v1 -> v2: > - support of_ensure_probed for top-level machine device > - ensure qemu board driver is probed at postcore > > Ahmad Fatoum (3): > boards: qemu-virt: apply overlay at postcore_initcall level > boards: qemu-virt: compile overlay as such > boards: qemu-virt: support passing in FIT public key > > common/boards/qemu-virt/Makefile | 2 +- > common/boards/qemu-virt/board.c | 52 +++++++++++-------- > common/boards/qemu-virt/fitimage-pubkey.dts | 7 +++ > .../{overlay-of-flash.dts => flash.dtso} | 0 > 4 files changed, 38 insertions(+), 23 deletions(-) > create mode 100644 common/boards/qemu-virt/fitimage-pubkey.dts > rename common/boards/qemu-virt/{overlay-of-flash.dts => flash.dtso} (100%) > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |