Re: [PATCH 1/2] usb: dwc2: core: add no-csftrst-wait DT property

Sascha Hauer
2026-04-15T06:39:17Z

Hi,

On Mon, Apr 13, 2026 at 01:41:28PM -0400, anis chali wrote:
> and I ended by removing it since it works for now without handling the versions.
>
> > > - ret = dwc2_wait_bit_clear(dwc2, GRSTCTL, GRSTCTL_CSFTRST, 10000);
> > > - if (ret) {
> > > - dwc2_warn(dwc2, "%s: Timeout! Waiting for Core Soft Reset\n",
> > > + /* Wait for at least 3 PHY Clocks */
> > > + udelay(1);
> > > +
> > > + if (!of_property_read_bool(np, "no-csftrst-wait")) {
> >
> > barebox-specific Device Tree properties should be documented in
> > Documentation/devicetree/bindings/.
> Okay, ack.
>
> > Alternatively, you can check of_machine_is_compatible("brcm,bcm2711")
> I choosed to add something in the device tree to not hard code a
> specific machine in
> dwc2 in that case we let the machine dts or users facing the same
> issue to add the dts
> property without even submitting patch, but if you prefer manage this
> with checking the
> machine compatible I can make the change???

The downside with the dts approach is that we never realize that it's
needed when that person doesn't submit a patch.

I prefer a machine compatible check at least until a pattern evolved
where this is needed.

Sascha