From: "Baeuerle, Florian" <Florian.Baeuerle@allegion.com>
To: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] recursive_action: add ACTION_SORT flag
Date: Tue, 8 Jan 2019 09:47:04 +0000 [thread overview]
Message-ID: <a86ae0154c6069405619d7752fcb227d5f2384b6.camel@allegion.com> (raw)
In-Reply-To: <20190107075821.x7gwx2mrlcyfvvz7@pengutronix.de>
NAK! NAK!
There are two terrible mistakes - indeed the patches produce a very reproducible
environment. Independent of what environment you want, you'd get an empty one.
Problem 1: a2f3b3d
it requires ACTION_RECURSE | ACTION_SORT
Problem 2: f5c0978
+ e->dirname = xstrdup(next->d_name);
should be much more like:
+ e->dirname = xstrdup(fileName);
Sorry for that, problem 2 should really *not* have happened.
- Florian
Am Montag, den 07.01.2019, 08:58 +0100 schrieb s.hauer@pengutronix.de:
> On Thu, Jan 03, 2019 at 11:53:27AM +0000, Baeuerle, Florian wrote:
> > Hi Sascha,
> >
> > thanks a lot!
> >
> > There's two things I noticed when reviewing the patches:
> >
> > The commit message of 47866ba5 is a bit misleading since poison.h is no
> > longer
> > being added in the commit.
> >
> > 861ce6d looks a bit weird, I guess that's a typo (ACTION_SORT |
> > ACTION_SORT).
>
> Ups, indeed. I fixed that.
>
> Thanks,
> Sascha
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-08 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:47 bareboxenv -s: output depends on filesystem Baeuerle, Florian
2018-12-17 10:53 ` Sascha Hauer
2018-12-18 13:22 ` [PATCH 1/2] recursive_action: add ACTION_SORT flag Baeuerle, Florian
2018-12-18 13:22 ` [PATCH 2/2] envfs: new flag for sorting env before saving Baeuerle, Florian
2018-12-19 12:42 ` [PATCH 1/2] recursive_action: add ACTION_SORT flag Baeuerle, Florian
2018-12-19 14:02 ` [PATCH v2 " Baeuerle, Florian
2018-12-19 14:02 ` [PATCH v2 2/2] envfs: new flag for sorting env before saving Baeuerle, Florian
2019-01-03 10:59 ` [PATCH v2 1/2] recursive_action: add ACTION_SORT flag Sascha Hauer
2019-01-03 11:53 ` Baeuerle, Florian
2019-01-07 7:58 ` s.hauer
2019-01-08 9:47 ` Baeuerle, Florian [this message]
2019-01-08 9:48 ` [PATCH 1/2] envfs: fix problem #1 Baeuerle, Florian
2019-01-08 9:48 ` [PATCH 2/2] envfs: fix problem #2 Baeuerle, Florian
2019-01-08 15:40 ` [PATCH v2 1/2] recursive_action: add ACTION_SORT flag s.hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86ae0154c6069405619d7752fcb227d5f2384b6.camel@allegion.com \
--to=florian.baeuerle@allegion.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox