[PATCH] pinctrl: at91: add sama5d3 compatible after DT regression

[PATCH] pinctrl: at91: add sama5d3 compatible after DT regression

[Lars Schmidt]

From: Lars Schmidt <lsc@pengutronix.de>

Commit f9abec74133a6 ("ARM: dts: microchip: Remove additional compatible
string from PIO3 pinctrl nodes") removed compatible string
atmel,at91sam9x5-pinctrl, which was used by pinctrl driver for sama3d3 in
barebox. Compatible string atmel,sama5d3-pinctrl was left in list, so
that needs to be included for identification.

The removal caused an issue during boot process. The system did still boot,
but no bootloader console was shown. Leaving the user without
possibility to interact with the bootloader.

The DT ABI breakage has been reported upstream:

https://lore.kernel.org/all/fcdb9283-07aa-4d50-ac4d-317b0a4e5f7e@pengutronix.de/

Signed-off-by: Lars Schmidt <lsc@pengutronix.de>
---
 drivers/pinctrl/pinctrl-at91.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index a3372a5035..ddc725187b 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -370,6 +370,9 @@ static struct at91_pinctrl_mux_ops at91sam9x5_ops = {
 
 static struct of_device_id at91_pinctrl_dt_ids[] = {
 	{
+		.compatible = "atmel,sama5d3-pinctrl",
+		.data = &at91sam9x5_ops,
+	}, {
 		.compatible = "atmel,at91rm9200-pinctrl",
 		.data = &at91rm9200_ops,
 	}, {
-- 
2.39.5

Re: [PATCH] pinctrl: at91: add sama5d3 compatible after DT regression

[Ahmad Fatoum]

Hi Lars,

On 4/16/25 17:30, Lars Schmidt wrote:
> From: Lars Schmidt <lsc@pengutronix.de>
> 
> Commit f9abec74133a6 ("ARM: dts: microchip: Remove additional compatible
> string from PIO3 pinctrl nodes") removed compatible string
> atmel,at91sam9x5-pinctrl, which was used by pinctrl driver for sama3d3 in
> barebox. Compatible string atmel,sama5d3-pinctrl was left in list, so
> that needs to be included for identification.
> 
> The removal caused an issue during boot process. The system did still boot,
> but no bootloader console was shown. Leaving the user without
> possibility to interact with the bootloader.
> 
> The DT ABI breakage has been reported upstream:
> 
> https://lore.kernel.org/all/fcdb9283-07aa-4d50-ac4d-317b0a4e5f7e@pengutronix.de/
> 
> Signed-off-by: Lars Schmidt <lsc@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  drivers/pinctrl/pinctrl-at91.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index a3372a5035..ddc725187b 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -370,6 +370,9 @@ static struct at91_pinctrl_mux_ops at91sam9x5_ops = {
>  
>  static struct of_device_id at91_pinctrl_dt_ids[] = {
>  	{
> +		.compatible = "atmel,sama5d3-pinctrl",
> +		.data = &at91sam9x5_ops,
> +	}, {
>  		.compatible = "atmel,at91rm9200-pinctrl",
>  		.data = &at91rm9200_ops,
>  	}, {

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

Re: [PATCH] pinctrl: at91: add sama5d3 compatible after DT regression

[Sascha Hauer]

On Wed, 16 Apr 2025 17:30:08 +0200, Lars Schmidt wrote:
> Commit f9abec74133a6 ("ARM: dts: microchip: Remove additional compatible
> string from PIO3 pinctrl nodes") removed compatible string
> atmel,at91sam9x5-pinctrl, which was used by pinctrl driver for sama3d3 in
> barebox. Compatible string atmel,sama5d3-pinctrl was left in list, so
> that needs to be included for identification.
> 
> The removal caused an issue during boot process. The system did still boot,
> but no bootloader console was shown. Leaving the user without
> possibility to interact with the bootloader.
> 
> [...]

Applied, thanks!

[1/1] pinctrl: at91: add sama5d3 compatible after DT regression
      https://git.pengutronix.de/cgit/barebox/commit/?id=9532f37b1171 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>

Re: [PATCH] pinctrl: at91: add sama5d3 compatible after DT regression

[Sascha Hauer]

On Wed, Apr 16, 2025 at 05:30:08PM +0200, Lars Schmidt wrote:
> From: Lars Schmidt <lsc@pengutronix.de>
> 
> Commit f9abec74133a6 ("ARM: dts: microchip: Remove additional compatible

Addded 'Linux' in front of 'Commit' to make clear where to look for this
commit.

Sascha

> string from PIO3 pinctrl nodes") removed compatible string
> atmel,at91sam9x5-pinctrl, which was used by pinctrl driver for sama3d3 in
> barebox. Compatible string atmel,sama5d3-pinctrl was left in list, so
> that needs to be included for identification.
> 
> The removal caused an issue during boot process. The system did still boot,
> but no bootloader console was shown. Leaving the user without
> possibility to interact with the bootloader.
> 
> The DT ABI breakage has been reported upstream:
> 
> https://lore.kernel.org/all/fcdb9283-07aa-4d50-ac4d-317b0a4e5f7e@pengutronix.de/
> 
> Signed-off-by: Lars Schmidt <lsc@pengutronix.de>
> ---
>  drivers/pinctrl/pinctrl-at91.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index a3372a5035..ddc725187b 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -370,6 +370,9 @@ static struct at91_pinctrl_mux_ops at91sam9x5_ops = {
>  
>  static struct of_device_id at91_pinctrl_dt_ids[] = {
>  	{
> +		.compatible = "atmel,sama5d3-pinctrl",
> +		.data = &at91sam9x5_ops,
> +	}, {
>  		.compatible = "atmel,at91rm9200-pinctrl",
>  		.data = &at91rm9200_ops,
>  	}, {
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |