Re: [PATCH master 3/4] ARM: k3: define debug_ll_write_reg only on CONFIG_DEBUG_AM62X_UART=y

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Apr 22, 2025 at 04:29:17PM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 4/22/25 16:23, Sascha Hauer wrote:
> > On Tue, Apr 22, 2025 at 09:55:18AM +0200, Ahmad Fatoum wrote:
> >> From: Ahmad Fatoum <a.fatoum@barebox.org>
> >>
> >> Defining debug_ll_read_reg unconditionally for K3 can clash with other
> >> debug_ll implementations, so move it into the include guard.
> >>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
> >> ---
> >>  include/mach/k3/debug_ll.h | 37 ++++++++++++++++++-------------------
> >>  1 file changed, 18 insertions(+), 19 deletions(-)
> > 
> > This breaks compilation of multi_v8_defconfig:
> > 
> > arch/arm/boards/beagleplay/lowlevel.c:44:30: error:  debug_ll_ns16550_putc' undeclared (first use in this function)
> >    44 |         pbl_set_putc((void *)debug_ll_ns16550_putc, (void *)AM62X_UART_UART0_BASE);
> > 
> > debug_ll_ns16550_putc() is used as the pbl putc function. This might
> > have been wrong from the start, but it is like it is.
> > 
> > Not sure what we should do about it. We would need some ns16550 putc
> > function that is independent of the debug_ll infrastructure.
> 
> Meh. This patch was a side product of Mediatek MT8186 support, which
> also has a NS16550. Please drop it for now and I'll revisit it later.

Yes, will do, but we have a problem even with existing code. Right now
we will run into the same issue when building a multi_v8_defconfig with
debug output configured for Layerscape or Rockchip.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |