From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 22 Apr 2025 17:49:12 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7Frz-0046tI-39 for lore@lore.pengutronix.de; Tue, 22 Apr 2025 17:49:11 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u7Frz-0008Ip-D6 for lore@pengutronix.de; Tue, 22 Apr 2025 17:49:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i75eUuB5oyv43K86P8EbBUMAO3z3Pv7ACSdPGQx2BwI=; b=uOyS2i4W/SMyN09e/1wNB+1aeP GhREBXNhmDOI3RPTz43e8dVU1YSzo183Out0SzG5PqjWDlw19igVqMV1cea7AqZc7aeuJ2MeDc/x7 Zr6tjyvY67uAug9BIi0KsShvBnPnowV9LjLExz2TWGMCq+cgEDBEyIfihIhYiNrxoid87Kpio9/Kq xfSjgbqt3ceHMKtLz6xWtQbQukqlFi7apGeLej+5AL5brTL0sJ8z1SqrjSOYIeZOSWO182YT5E7EC PrauKSbEmFldiKBm7HX0/bh13NqxqRgq26SE0SqLlDM2biHbgLdTuOM6xKG53+yAMSn9m4NNBSTzS ydPFdPeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7FrX-00000007n1O-0nMR; Tue, 22 Apr 2025 15:48:43 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7Ehl-00000007WHh-0IxX for barebox@lists.infradead.org; Tue, 22 Apr 2025 14:34:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u7Ehj-0000Aj-KF; Tue, 22 Apr 2025 16:34:31 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7Ehj-001ZJY-1Q; Tue, 22 Apr 2025 16:34:31 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1u7Ehj-00FAld-14; Tue, 22 Apr 2025 16:34:31 +0200 Date: Tue, 22 Apr 2025 16:34:31 +0200 From: Sascha Hauer To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: References: <20250422075519.219029-1-a.fatoum@pengutronix.de> <20250422075519.219029-3-a.fatoum@pengutronix.de> <4f94213d-10af-4122-a16f-0e1e0a9c679e@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f94213d-10af-4122-a16f-0e1e0a9c679e@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250422_073433_106907_1162BE2B X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master 3/4] ARM: k3: define debug_ll_write_reg only on CONFIG_DEBUG_AM62X_UART=y X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Tue, Apr 22, 2025 at 04:29:17PM +0200, Ahmad Fatoum wrote: > Hello Sascha, > > On 4/22/25 16:23, Sascha Hauer wrote: > > On Tue, Apr 22, 2025 at 09:55:18AM +0200, Ahmad Fatoum wrote: > >> From: Ahmad Fatoum > >> > >> Defining debug_ll_read_reg unconditionally for K3 can clash with other > >> debug_ll implementations, so move it into the include guard. > >> > >> Signed-off-by: Ahmad Fatoum > >> --- > >> include/mach/k3/debug_ll.h | 37 ++++++++++++++++++------------------- > >> 1 file changed, 18 insertions(+), 19 deletions(-) > > > > This breaks compilation of multi_v8_defconfig: > > > > arch/arm/boards/beagleplay/lowlevel.c:44:30: error: debug_ll_ns16550_putc' undeclared (first use in this function) > > 44 | pbl_set_putc((void *)debug_ll_ns16550_putc, (void *)AM62X_UART_UART0_BASE); > > > > debug_ll_ns16550_putc() is used as the pbl putc function. This might > > have been wrong from the start, but it is like it is. > > > > Not sure what we should do about it. We would need some ns16550 putc > > function that is independent of the debug_ll infrastructure. > > Meh. This patch was a side product of Mediatek MT8186 support, which > also has a NS16550. Please drop it for now and I'll revisit it later. Yes, will do, but we have a problem even with existing code. Right now we will run into the same issue when building a multi_v8_defconfig with debug output configured for Layerscape or Rockchip. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |