Re: [PATCH 2/5] scripts: rockchip: add helper for updating hash

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Michael,

On Thu, Jul 31, 2025 at 12:48:22PM +0200, Michael Tretter wrote:
> The idb contains a flag for the used hash type. Use the flag to
> determine the used hash function and update the hash accordingly.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
>  scripts/rkimage.c | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/rkimage.c b/scripts/rkimage.c
> index ba89f32d9376d0153692baa3ddde1c793c1e4cc2..fd97bd1dd9f5967762d0a8bf9d186594a05a2a9f 100644
> --- a/scripts/rkimage.c
> +++ b/scripts/rkimage.c
> @@ -42,6 +42,17 @@ static void sha512(const void *buf, int len, void *out)
>  	EVP_MD_CTX_free(md_ctx);
>  }
>  
> +static void idb_hash(struct newidb *idb)
> +{
> +	unsigned char *idbu8 = (void *)idb;
> +	size_t size = 1536;
> +
> +	if (!!(idb->flags & NEWIDB_FLAGS_SHA256))
> +		sha256(idbu8, size, idbu8 + size);
> +	else if (!!(idb->flags & NEWIDB_FLAGS_SHA512))
> +		sha512(idbu8, size, idbu8 + size);
> +}

Drop these double negations.

NEWIDB_FLAGS_* are defined in the next patch, should be here.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |