From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 26 Sep 2025 14:41:28 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v27lQ-001KZt-2x for lore@lore.pengutronix.de; Fri, 26 Sep 2025 14:41:28 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v27lQ-0003k4-7T for lore@pengutronix.de; Fri, 26 Sep 2025 14:41:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wGL8WwkoCT2MZkhxutyRNhnCNjs8WAJe2lVEhikrpNQ=; b=21eMkU1EXOITEKE9kfPNDDKENY yfV88E9wUZ3Y/F4Z9JhjRKUPkNarTPdmO1dBJJIgDOvf5evgl/L3pHcyAf5SKnNwLU52vFt0jvEP1 NyetOcUdruNyFSme3QkI2YDUbvm85QNDwUs2PW+CVbHCqCvFkL87j6d5WipdaPyNfbzURXQr6x+rK bwDD0HTWQLxwUjxbgQ2Q1hQ79bXFAR7ikYXlxJV3dmkM8vY1mB6tYuvMN6EPx2GNI8OQkrxAS5Lvf Zk0J2e3LFLp/drwqLcDDUUNTgUNzruqWJYXRa2ukUr8QkRadXjFwYXGTgF1w358nA70WkUECnrGyh S/jacQmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v27kh-00000001FBg-1mvo; Fri, 26 Sep 2025 12:40:43 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v27ke-00000001F8V-43ba for barebox@lists.infradead.org; Fri, 26 Sep 2025 12:40:42 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v27kd-0003Z3-CG; Fri, 26 Sep 2025 14:40:39 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v27kd-000aod-0B; Fri, 26 Sep 2025 14:40:39 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1v27kc-00EVqQ-31; Fri, 26 Sep 2025 14:40:38 +0200 Date: Fri, 26 Sep 2025 14:40:38 +0200 From: Sascha Hauer To: David Picard Cc: BAREBOX Message-ID: References: <20250925-boards-enclustra-sa2-add-support-v2-0-6820ad6c6256@clermont.in2p3.fr> <20250925-boards-enclustra-sa2-add-support-v2-5-6820ad6c6256@clermont.in2p3.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250925-boards-enclustra-sa2-add-support-v2-5-6820ad6c6256@clermont.in2p3.fr> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250926_054041_005408_2FA369B7 X-CRM114-Status: GOOD ( 33.26 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 05/10] boards: enclustra-sa2: read MAC address from EEPROM X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Thu, Sep 25, 2025 at 01:59:12PM +0200, David Picard wrote: > Signed-off-by: David Picard > > --- > v1 --> v2: > - Use the atsha204a driver to read the MAC address instead of > board-specific code. > --- > --- > arch/arm/boards/enclustra-sa2/board.c | 74 +++++++++++++++++++++++++- > arch/arm/dts/socfpga_cyclone5_mercury_sa2.dtsi | 16 +++++- > 2 files changed, 87 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boards/enclustra-sa2/board.c b/arch/arm/boards/enclustra-sa2/board.c > index d3117e9a1058738ea541f45b28c6a95184331554..4c2b44252d84c78ed8de5754051d0bf194ce8d02 100644 > --- a/arch/arm/boards/enclustra-sa2/board.c > +++ b/arch/arm/boards/enclustra-sa2/board.c > @@ -12,6 +12,12 @@ > #include > #include > #include > +#include > +#include > + > +/** Enclustra's MAC address vendor prefix is 20:B0:F7 */ > +#define ENCLUSTRA_PREFIX (0x20b0f7) > +#define MAC_ADDR_NUM_BYTES (6) > > /* > * Ethernet PHY: Microchip/Micrel KSZ9031RNX > @@ -21,14 +27,78 @@ static int phy_fixup(struct phy_device *dev) > return 0; > } > > +/* > + * Read the MAC address via the atsha204a driver. > + * > + * Set two consecutive MAC addresses, as specified by the manufacturer. > + */ > +static void set_mac_addr(void) > +{ > + uint8_t hwaddr[MAC_ADDR_NUM_BYTES] = { 0, 0, 0, 0, 0, 0 }; > + uint32_t hwaddr_prefix; > + u8 *data = NULL; > + static const char * const aliases[] = { "ethernet0" }; > + struct device_node *np, *root; > + /* Fallback MAC addresses, used if we can't read from EEPROM: */ > + const uint8_t enclustra_ethaddr_fallback1[] = { 0x20, 0xB0, 0xF7, 0x01, > + 0x02, 0x03 }; > + const uint8_t enclustra_ethaddr_fallback2[] = { 0x20, 0xB0, 0xF7, 0x01, > + 0x02, 0x04 }; Please no fallback addresses. Just skip setting these and barebox will use a random MAC. > + > + root = of_get_root_node(); > + > + for (int i = 0; i < ARRAY_SIZE(aliases); i++) { > + const char *alias = aliases[i]; > + np = of_find_node_by_alias(root, alias); > + if (!np) { > + pr_warn("%s() >> ERROR: can't find alias %s\n", __func__, alias); > + continue; > + } > + data = nvmem_cell_get_and_read(np, "mac-address", MAC_ADDR_NUM_BYTES); > + if (IS_ERR(data)) { > + pr_warn("%s() >> ERROR: can't read NVMEM cell\n", __func__); > + data = NULL; > + } > + } You shouldn't need this. of_get_mac_addr_nvmem() called by the net layer during startup should handle this for you. > + if (!data) > + goto fallback_addr; > + > + memcpy(hwaddr, data, MAC_ADDR_NUM_BYTES); > + > + debug("MAC address: %02x:%02x:%02x:%02x:%02x:%02x\n", > + hwaddr[0], hwaddr[1], hwaddr[2], > + hwaddr[3], hwaddr[4], hwaddr[5]); > + > + /* check vendor prefix and set the environment variable */ > + hwaddr_prefix = (hwaddr[0] << 16) | (hwaddr[1] << 8) | (hwaddr[2]); > + if (hwaddr_prefix == ENCLUSTRA_PREFIX) { > + eth_register_ethaddr(0, hwaddr); > + hwaddr[5]++; /* calculate 2nd, consecutive MAC address */ > + eth_register_ethaddr(1, hwaddr); > + } else { > + printf("%s() >> ERROR: invalid MAC address vendor prefix," > + "using fallback addresses\n", __func__); > + goto fallback_addr; > + } Not sure what to do about the consecutive MAC address. There seems to be beginning support for this in fixed-cell.yaml, but I can't find an implementation for it. > diff --git a/arch/arm/dts/socfpga_cyclone5_mercury_sa2.dtsi b/arch/arm/dts/socfpga_cyclone5_mercury_sa2.dtsi > index fa80b7c63d28d17a24d63ac3ee87531ad320ddb1..55d54d289c81fa4a6d46123bcb93c5fc483485e4 100644 > --- a/arch/arm/dts/socfpga_cyclone5_mercury_sa2.dtsi > +++ b/arch/arm/dts/socfpga_cyclone5_mercury_sa2.dtsi > @@ -76,6 +76,19 @@ atsha204a: atsha204a@64 { > status = "okay"; > compatible = "atmel,atsha204a"; > reg = <0x64>; > + > + nvmem-layout { > + compatible = "fixed-layout"; > + #address-cells = <1>; > + #size-cells = <1>; Indentation wrong here. > + > + mac_address_0: mac@10 { > + compatible = "mac-base"; > + reg = <0x10 0x6>; > + nvmem-cell-cells = <1>; must be #nvmem-cell-cells# Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |