mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jonas Rebmann <jre@pengutronix.de>
Cc: BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH] gitignore: ignore /build
Date: Mon, 20 Oct 2025 15:01:42 +0200	[thread overview]
Message-ID: <aPYythjw3db3xZ1m@pengutronix.de> (raw)
In-Reply-To: <8c12af27-89c1-4f7a-8f10-807c25ab147c@pengutronix.de>

On Mon, Oct 20, 2025 at 02:36:08PM +0200, Jonas Rebmann wrote:
> Hi Sascha,
> 
> On 2025-10-20 11:44, Sascha Hauer wrote:
> > On Fri, Oct 17, 2025 at 12:22:13PM +0200, Jonas Rebmann wrote:
> > > Documentation such as Documentation/boards/kvx.rst and tooling such as
> > > conftest.py suggests /build is a good choice for build output directory.
> > > 
> > > Therefore, include it in .gitignore.
> > > 
> > > Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
> > > ---
> > >   .gitignore | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/.gitignore b/.gitignore
> > > index 98bb4dac89..32d54b8fbe 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -53,6 +53,7 @@ policy-list
> > >   /TAGS
> > >   /barebox*
> > >   /System.map
> > > +/build
> > 
> > I have nothing against adding this here. I just wondered why my build
> > directories don't show up in git status and realized the barebox
> > toplevel Makefile already creates a .gitignore file in the build
> > directory:
> > 
> > 	{ echo "# this is build directory, ignore it"; echo "*"; } > .gitignore
> > 
> > Any idea why this doesn't happen in your case?
> 
> Oh, I was not aware of this.
> 
> In my case, "build" is a symlink to outside the barebox sourcetree. The
> build/.gitignore is created with this content but it isn't respected by
> git because it isn't in the sourcetree. This is also why I added
> '/build' to .gitignore and not '/build/': To also ignore it when it's a
> symlink.

Ah, ok, so the symlink is the problem. YOCTO uses a build symlink as
well when used with devtool modify --no-extract. With YOCTO we also get
oe-logs and oe-workdir symlinks, so maybe we should git-ignore these as
well.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2025-10-20 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 10:22 Jonas Rebmann
2025-10-20  9:44 ` Sascha Hauer
2025-10-20 12:36   ` Jonas Rebmann
2025-10-20 13:01     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPYythjw3db3xZ1m@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jre@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox