Re: [PATCH 5/5] mci: cadence: add support for version 6

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Steffen,

On Mon, Dec 15, 2025 at 03:21:27PM +0100, Steffen Trumtrar wrote:
> There is a v4 and a v6 of the Cadence SDHCI. The Agilex actually has the
> v6 version on the SoC.
> 
> Port the driver from Alteras Linux tree [1]
> 
> [1]: https://github.com/altera-fpga/linux-socfpga.git socfpga-6.12.33-lts
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  drivers/mci/Makefile         |   2 +-
>  drivers/mci/cadence-sdhci.c  | 714 ++++++++++++++++++++-----------------------
>  drivers/mci/cadence-sdhci.h  | 118 +++++++
>  drivers/mci/cadence-sdhci6.c | 373 ++++++++++++++++++++++
>  4 files changed, 818 insertions(+), 389 deletions(-)

This changes the whole driver. As the original driver only has a single
commit and is not enabled in any defconfig, could you remove the original
driver first and add this driver in a second step? This would make this
patch more readable.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |