[PATCH 1/2] usb: gadget: initialize serialnumber as empty string

[PATCH 1/2] usb: gadget: initialize serialnumber as empty string

[Marco Felsch]

Windows hosts do require the serial number to be set to any ascii string
to enumerate correctly. Set the serial number to "empty" to provide a
sane default which works for both hosts. Users can still override this
via the gadget.serialnumber variable.

Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/usb/gadget/udc/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index b58498680ad1..dc5d1daa14bf 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -1204,7 +1204,7 @@ int usb_add_gadget(struct usb_gadget *gadget)
 	gadget->productname = xstrdup(barebox_get_model());
 	dev_add_param_string(&gadget->dev, "productname", NULL, NULL,
 			     &gadget->productname, NULL);
-	gadget->serialnumber = xstrdup("");
+	gadget->serialnumber = xstrdup("empty");
 	dev_add_param_string(&gadget->dev, "serialnumber", NULL, NULL,
 			     &gadget->serialnumber, NULL);
 
-- 
2.39.2

[PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Marco Felsch]

The status parameter is never used so drop it and stop bother the user
of the script.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 scripts/get_maintainer.pl | 2 --
 1 file changed, 2 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7c0d50333400..a19c0e7305d0 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -2,8 +2,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 # Dummy get_maintainer.pl script for checkpatch.pl to use
 
-die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
-
 print <<'EOT'
 Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
 barebox@lists.infradead.org (open list:BAREBOX)
-- 
2.39.2

Re: [PATCH 1/2] usb: gadget: initialize serialnumber as empty string

[Ahmad Fatoum]

Hello Marco,

On 26.10.23 14:46, Marco Felsch wrote:
> Windows hosts do require the serial number to be set to any ascii string
> to enumerate correctly. Set the serial number to "empty" to provide a
> sane default which works for both hosts. Users can still override this
> via the gadget.serialnumber variable.
> 
> Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  drivers/usb/gadget/udc/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index b58498680ad1..dc5d1daa14bf 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -1204,7 +1204,7 @@ int usb_add_gadget(struct usb_gadget *gadget)
>  	gadget->productname = xstrdup(barebox_get_model());
>  	dev_add_param_string(&gadget->dev, "productname", NULL, NULL,
>  			     &gadget->productname, NULL);
> -	gadget->serialnumber = xstrdup("");
> +	gadget->serialnumber = xstrdup("empty");

Given that we initialize productname to model, it makes sense to initialize
serialnumber to global.serial_number now that we have that generic variable.

If that's unset, you can use a fixed value, I'd prefer "unset" though
instead of "empty".

Cheers,
Ahmad

>  	dev_add_param_string(&gadget->dev, "serialnumber", NULL, NULL,
>  			     &gadget->serialnumber, NULL);
>  

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Ahmad Fatoum]

On 26.10.23 14:46, Marco Felsch wrote:
> The status parameter is never used so drop it and stop bother the user
> of the script.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Our get_maintainer.pl script doesn't have the same breadth of features
as the kernel's and only --status is implemented, thus the check.

> ---
>  scripts/get_maintainer.pl | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 7c0d50333400..a19c0e7305d0 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -2,8 +2,6 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  # Dummy get_maintainer.pl script for checkpatch.pl to use
>  
> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
> -
>  print <<'EOT'
>  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
>  barebox@lists.infradead.org (open list:BAREBOX)

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Marco Felsch]

On 23-10-26, Ahmad Fatoum wrote:
> On 26.10.23 14:46, Marco Felsch wrote:
> > The status parameter is never used so drop it and stop bother the user
> > of the script.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> Our get_maintainer.pl script doesn't have the same breadth of features
> as the kernel's and only --status is implemented, thus the check.

Where? I see only 'print << 'EOT' <text> EOT'

Regards,
  Marco

> 
> > ---
> >  scripts/get_maintainer.pl | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > index 7c0d50333400..a19c0e7305d0 100755
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -2,8 +2,6 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> >  # Dummy get_maintainer.pl script for checkpatch.pl to use
> >  
> > -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
> > -
> >  print <<'EOT'
> >  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
> >  barebox@lists.infradead.org (open list:BAREBOX)
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Ahmad Fatoum]

On 26.10.23 16:27, Marco Felsch wrote:
> On 23-10-26, Ahmad Fatoum wrote:
>> On 26.10.23 14:46, Marco Felsch wrote:
>>> The status parameter is never used so drop it and stop bother the user
>>> of the script.
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>
>> Our get_maintainer.pl script doesn't have the same breadth of features
>> as the kernel's and only --status is implemented, thus the check.
> 
> Where? I see only 'print << 'EOT' <text> EOT'

Ye, the output is similar to what you'd get with the kernel's --status.
The script is just here, because checkpatch depends on it and calls
it with --status.

Cheers,
Ahmad

> 
> Regards,
>   Marco
> 
>>
>>> ---
>>>  scripts/get_maintainer.pl | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
>>> index 7c0d50333400..a19c0e7305d0 100755
>>> --- a/scripts/get_maintainer.pl
>>> +++ b/scripts/get_maintainer.pl
>>> @@ -2,8 +2,6 @@
>>>  # SPDX-License-Identifier: GPL-2.0-only
>>>  # Dummy get_maintainer.pl script for checkpatch.pl to use
>>>  
>>> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
>>> -
>>>  print <<'EOT'
>>>  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
>>>  barebox@lists.infradead.org (open list:BAREBOX)
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 1/2] usb: gadget: initialize serialnumber as empty string

[Marco Felsch]

On 23-10-26, Ahmad Fatoum wrote:
> Hello Marco,
> 
> On 26.10.23 14:46, Marco Felsch wrote:
> > Windows hosts do require the serial number to be set to any ascii string
> > to enumerate correctly. Set the serial number to "empty" to provide a
> > sane default which works for both hosts. Users can still override this
> > via the gadget.serialnumber variable.
> > 
> > Reported-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  drivers/usb/gadget/udc/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> > index b58498680ad1..dc5d1daa14bf 100644
> > --- a/drivers/usb/gadget/udc/core.c
> > +++ b/drivers/usb/gadget/udc/core.c
> > @@ -1204,7 +1204,7 @@ int usb_add_gadget(struct usb_gadget *gadget)
> >  	gadget->productname = xstrdup(barebox_get_model());
> >  	dev_add_param_string(&gadget->dev, "productname", NULL, NULL,
> >  			     &gadget->productname, NULL);
> > -	gadget->serialnumber = xstrdup("");
> > +	gadget->serialnumber = xstrdup("empty");
> 
> Given that we initialize productname to model, it makes sense to initialize
> serialnumber to global.serial_number now that we have that generic variable.
> 
> If that's unset, you can use a fixed value, I'd prefer "unset" though
> instead of "empty".

I will adapt it, thanks.

Regards,
  Marco

Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Marco Felsch]

On 23-10-26, Ahmad Fatoum wrote:
> On 26.10.23 16:27, Marco Felsch wrote:
> > On 23-10-26, Ahmad Fatoum wrote:
> >> On 26.10.23 14:46, Marco Felsch wrote:
> >>> The status parameter is never used so drop it and stop bother the user
> >>> of the script.
> >>>
> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> >>
> >> Our get_maintainer.pl script doesn't have the same breadth of features
> >> as the kernel's and only --status is implemented, thus the check.
> > 
> > Where? I see only 'print << 'EOT' <text> EOT'
> 
> Ye, the output is similar to what you'd get with the kernel's --status.
> The script is just here, because checkpatch depends on it and calls
> it with --status.

You still can run it with --status, I just won't enforce it. At least to
me it's not clear why we need to enforce it and I use the script from
time to time and always forget the param.

Regards,
  Marco

> 
> Cheers,
> Ahmad
> 
> > 
> > Regards,
> >   Marco
> > 
> >>
> >>> ---
> >>>  scripts/get_maintainer.pl | 2 --
> >>>  1 file changed, 2 deletions(-)
> >>>
> >>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> >>> index 7c0d50333400..a19c0e7305d0 100755
> >>> --- a/scripts/get_maintainer.pl
> >>> +++ b/scripts/get_maintainer.pl
> >>> @@ -2,8 +2,6 @@
> >>>  # SPDX-License-Identifier: GPL-2.0-only
> >>>  # Dummy get_maintainer.pl script for checkpatch.pl to use
> >>>  
> >>> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
> >>> -
> >>>  print <<'EOT'
> >>>  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
> >>>  barebox@lists.infradead.org (open list:BAREBOX)
> >>
> >> -- 
> >> Pengutronix e.K.                           |                             |
> >> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> >> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> >> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> >>
> >>
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

Re: [PATCH 2/2] scripts: get_maintainers: drop --status enforcement

[Ahmad Fatoum]

On 26.10.23 16:34, Marco Felsch wrote:
> On 23-10-26, Ahmad Fatoum wrote:
>> On 26.10.23 16:27, Marco Felsch wrote:
>>> On 23-10-26, Ahmad Fatoum wrote:
>>>> On 26.10.23 14:46, Marco Felsch wrote:
>>>>> The status parameter is never used so drop it and stop bother the user
>>>>> of the script.
>>>>>
>>>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>>>
>>>> Our get_maintainer.pl script doesn't have the same breadth of features
>>>> as the kernel's and only --status is implemented, thus the check.
>>>
>>> Where? I see only 'print << 'EOT' <text> EOT'
>>
>> Ye, the output is similar to what you'd get with the kernel's --status.
>> The script is just here, because checkpatch depends on it and calls
>> it with --status.
> 
> You still can run it with --status, I just won't enforce it. At least to
> me it's not clear why we need to enforce it and I use the script from
> time to time and always forget the param.

The idea was not to mislead users that assume that barebox get_maintainers.pl
behaves the same as Linux. But now thinking about it, just printing the same
always won't hurt.

>>>>> -die "USAGE: get_maintainer.pl --status\n" unless grep /--status/, @ARGV;
>>>>> -
>>>>>  print <<'EOT'
>>>>>  Sascha Hauer <s.hauer@pengutronix.de> (maintainer:BAREBOX)
>>>>>  barebox@lists.infradead.org (open list:BAREBOX)
>>>>
>>>> -- 
>>>> Pengutronix e.K.                           |                             |
>>>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>>>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>>>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>>>
>>>>
>>>
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |