From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 03 Jul 2023 10:47:31 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGFDY-00DHus-Qr for lore@lore.pengutronix.de; Mon, 03 Jul 2023 10:47:31 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGFDW-0008SF-Eg for lore@pengutronix.de; Mon, 03 Jul 2023 10:47:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w1XGLsLuYOAwlMHAu7d4Kgv5bn2cXNzYyI/2e5fYnHs=; b=DG4ih0GXdAE45n6V7oQ/imyWe8 Cz36sDDfpsxj1qYngIYxmVCWbAfhZqdlz8tTk2QuwZAAaQTLbIHvLqym64sFKotzSnsIrV5mrmFjp dB4ukReCpcYeDtZ6TCkdEIRqJzaErk51NpuQqrNrsaYWOnAP7skRHBR0p7VO3vcepQY2WERRyx723 3xUJFk1eQUWdmHeetq7Mni4IzRBqLxbZaC0rCoOCKVdt9BR+txCpY4GFVUynSH+LMkglQ3vT1lg6/ w5klR/VkJlGTPyY7x5c0XFIsQ7C0/Iit67TRENqDY2RjQNbicM9U8I1H/ikW/2NnCJpMzoV5YKRBd 6VcMP0rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGFCR-009nUI-2a; Mon, 03 Jul 2023 08:46:23 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGFCO-009nTV-0x for barebox@lists.infradead.org; Mon, 03 Jul 2023 08:46:21 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qGFCM-0008Lh-Vb; Mon, 03 Jul 2023 10:46:19 +0200 Message-ID: Date: Mon, 3 Jul 2023 10:46:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Marco Felsch Cc: barebox@lists.infradead.org, uol@pengutronix.de References: <20230626153335.3592017-1-a.fatoum@pengutronix.de> <20230626153335.3592017-6-a.fatoum@pengutronix.de> <20230703063314.vfp4lgig3wafxqjz@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230703063314.vfp4lgig3wafxqjz@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230703_014620_339972_16656026 X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master v1 5/6] ARM64: unset CONFIG_MISSING_FIRMWARE_ERROR for Rockchip/i.MX X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 03.07.23 08:33, Marco Felsch wrote: > On 23-06-26, Ahmad Fatoum wrote: >> barebox ARMv8 images for Rockchip and i.MX depend on external firmware >> for RAM setup (e.g. DDR PHY firmware) and on a BL31 binary to service >> secure monitor calls of the operating system (usually TF-A). >> >> Images without this firmware are not functional and the build warns >> about it, yet for development, it's more convenient to have the build >> not fail. This is especially useful for multi_v8_defconfig, which also >> builds the drivers Qemu Virt64 image and which requires no extra >> firmware. > > IMHO most user just use the defconfig as base and so they never notice > the new CONFIG_MISSING_FIRMWARE_ERROR switch. Since you have added a > great mechanism to inform the user that a particular barebox-bin is > missing firmware-files I would tend to set this config to 'n'. I can't follow the reasoning. Some people will not benefit from the default, so just remove the default? > > Regards, > Marco > >> Signed-off-by: Ahmad Fatoum >> --- >> arch/arm/configs/imx_v8_defconfig | 1 + >> arch/arm/configs/multi_v8_defconfig | 1 + >> arch/arm/configs/rockchip_v8_defconfig | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/arch/arm/configs/imx_v8_defconfig b/arch/arm/configs/imx_v8_defconfig >> index 93b85ff5ea40..99d871bfb968 100644 >> --- a/arch/arm/configs/imx_v8_defconfig >> +++ b/arch/arm/configs/imx_v8_defconfig >> @@ -147,3 +147,4 @@ CONFIG_FS_FAT_WRITE=y >> CONFIG_FS_FAT_LFN=y >> CONFIG_FS_RATP=y >> CONFIG_ZLIB=y >> +# CONFIG_MISSING_FIRMWARE_ERROR is not set >> diff --git a/arch/arm/configs/multi_v8_defconfig b/arch/arm/configs/multi_v8_defconfig >> index e0ff21641a01..76b80975887d 100644 >> --- a/arch/arm/configs/multi_v8_defconfig >> +++ b/arch/arm/configs/multi_v8_defconfig >> @@ -241,3 +241,4 @@ CONFIG_FS_PSTORE=y >> CONFIG_FS_PSTORE_CONSOLE=y >> CONFIG_FS_RATP=y >> CONFIG_LZO_DECOMPRESS=y >> +# CONFIG_MISSING_FIRMWARE_ERROR is not set >> diff --git a/arch/arm/configs/rockchip_v8_defconfig b/arch/arm/configs/rockchip_v8_defconfig >> index cc3c3c6d489b..7d1d41965ece 100644 >> --- a/arch/arm/configs/rockchip_v8_defconfig >> +++ b/arch/arm/configs/rockchip_v8_defconfig >> @@ -149,3 +149,4 @@ CONFIG_FS_FAT_LFN=y >> CONFIG_FS_BPKFS=y >> CONFIG_FS_UIMAGEFS=y >> CONFIG_LZO_DECOMPRESS=y >> +# CONFIG_MISSING_FIRMWARE_ERROR is not set >> -- >> 2.39.2 >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |