From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 02 Jun 2026 19:12:20 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUSf6-001eQK-0n for lore@lore.pengutronix.de; Tue, 02 Jun 2026 19:12:20 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wUSf4-0008Rr-DS for lore@pengutronix.de; Tue, 02 Jun 2026 19:12:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gxwj8n6wumIh7/vBTVtUnZRgdXPhMdLjAim0kwEyC9Y=; b=qwjIXHA81QBFO7yfM4LTnOBaHn 1Mj5xTxJueQdtm8yNPBTAHFFcxvU12XKh4hl+cVwmIKHlPRPazi+PmLUFlg8vL78HQ6kRZGySUYLm ACWi0lKXGw20Uzckvb9GvzWdfJM3nDgmme39PQUIMVhNLfnLdLzQmvNDHjvXNr8OslZDP4DzNdp0C tQ9TU9EBrGPnGf/Wz9Ijf/pVXJpeLY0FEcHH/77rQ5heURW1prQUrg6nMc86geU68bPiJyOG7NCi0 JqYUfrTkhoIgo3V3LYjNtxfLansXyDQJBb5hlNkOReLeVBu03dBtbzOPr6gDFz/WTAW5Uct9uYRSa 8mwBhKOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUSdX-0000000DYVn-1Wju; Tue, 02 Jun 2026 17:10:43 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wUSdW-0000000DYVJ-0GKQ for barebox@lists.infradead.org; Tue, 02 Jun 2026 17:10:42 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 81ECA6001A; Tue, 2 Jun 2026 17:10:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07D841F00893; Tue, 2 Jun 2026 17:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780420241; bh=gxwj8n6wumIh7/vBTVtUnZRgdXPhMdLjAim0kwEyC9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XUBqKodsPS2xYZ4P2UR9GpecDnNg2dKw0n4XUd2GlG5qwz6FielbCBvUv+eAsg5WT D7UiUbNhzTQOmW71nIPjLsxUoO8a6JgLA4O8+v0LaoJE1B8XFJBVHZ06tV6L9nnBzA Air14S3C3MGRRjJV/dqqCNirtKbslA4cnl6qvF2KBCebfmp0obXf/U2mhRWvQs0rxP OoMoZpU17TaVSgYI6mvggFWgWZIdHAWZBieLQyW/fTKazAXVl3d98jLDkwOGwyD9qD qbzUWTKKHKNlQZcVTXeI3YccPphNYz0VJZ8I3713csM+Y36h5pMnToc90sDdkh4v/n yyhpl9i8clJ9g== Date: Tue, 2 Jun 2026 19:10:36 +0200 From: Michael Grzeschik To: Lucas Stach Cc: Ahmad Fatoum , Johannes Schneider , barebox@lists.infradead.org, thomas.haemmerle@leica-geosystems.com Message-ID: References: <20260602040953.1060278-1-johannes.schneider@leica-geosystems.com> <20260602040953.1060278-7-johannes.schneider@leica-geosystems.com> <54467182b9e4f15a1ac068533e73aaac5f21bf46.camel@pengutronix.de> <679f1823-5edd-4a8f-8a8e-caf6db7dd483@pengutronix.de> <9bf1b5920ca2c986533c5f17d10aa774aa60c895.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9bf1b5920ca2c986533c5f17d10aa774aa60c895.camel@pengutronix.de> X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-105.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 6/6] video: imx-lcdif: drain write-combine buffer before LCDIF DMA reads pixels X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Tue, Jun 02, 2026 at 02:12:43PM +0200, Lucas Stach wrote: > Am Dienstag, dem 02.06.2026 um 11:37 +0200 schrieb Ahmad Fatoum: > > > > On 6/2/26 10:12 AM, Lucas Stach wrote: > > > Am Dienstag, dem 02.06.2026 um 04:09 +0000 schrieb Johannes Schneider: > > > > From: Thomas Haemmerle > > > > > > > > The LCDIF framebuffer is allocated as Normal Non-Cacheable (write-combine) > > > > memory. After the splash command calls gu_screen_blit(), which copies the > > > > decoded PNG via memcpy() from a cached shadow buffer into the hardware > > > > framebuffer, writes may still reside in the CPU write buffer and not yet > > > > be visible to the LCDIF DMA engine. On hardware this manifests as > > > > partial or corrupted rendering — the bottom portion of the splash image > > > > renders black or shows garbage. > > > > > > > > Implement fb_damage() to execute a DSB SY barrier after each blit, > > > > ensuring all pending write-combine writes are committed to DRAM before > > > > the LCDIF reads the pixel data. > > > > > > > > Assisted-by: Claude:claude-sonnet-4-6 > > > > Signed-of-by: Thomas Haemmerle > > > > --- > > > > drivers/video/imx-lcdif.c | 13 +++++++++++++ > > > > 1 file changed, 13 insertions(+) > > > > > > > > diff --git a/drivers/video/imx-lcdif.c b/drivers/video/imx-lcdif.c > > > > index ae5976c771..8d9b40be0f 100644 > > > > --- a/drivers/video/imx-lcdif.c > > > > +++ b/drivers/video/imx-lcdif.c > > > > @@ -20,6 +20,7 @@ > > > > #include > > > > #include