mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: any value in allowing user selection of barebox prompt?
Date: Tue, 7 Feb 2012 06:13:58 -0500 (EST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1202070608280.17306@oneiric> (raw)
In-Reply-To: <20120207093342.GB3852@pengutronix.de>

On Tue, 7 Feb 2012, Sascha Hauer wrote:

> On Mon, Feb 06, 2012 at 10:57:22AM -0500, Robert P. J. Day wrote:

... snip ...

> >   i tried it and it seems to work fine although the aesthetics in
> > "make menuconfig" is a bit strange WRT order:
> >
> >     (Texas Instrument's Beagle) Board info
> >         Select OMAP board (Texas Instrument's Beagle Board)  --->
> >
> > but that could be fixed just by moving the BOARDINFO entry below the
> > board choice in that file.
> >
> >   was this already discussed and rejected once upon a time?  it's not
> > a big deal but it has the value of being moderately informative.
>
> It hasn't been discussed before. It's mostly the way it is because I
> did it that way without much thinking. The change you suggest has
> one drawback. Consider you do a make menuconfig and change the
> board. Currently BOARDINFO correctly changes to the new board, but
> if we prompt the user for BOARDINFO the board string will still have
> the name of the old board.

  i'd noticed that but didn't know if there was any way to resolve
it easily.

> I think the board name does not have to come from Kconfig anyway.
> How about keeping things in Kconfig how they are but instead of
> using CONFIG_BOARDINFO directly we could use a string. This string
> defaults to CONFIG_BOARDINFO but can be overwritten by board code by
> calling a set_boardinfo(const char *) function. For new boards we
> could use this exclusively and maybe convert the existing boards
> over to it.

  i didn't want to make a big deal of this, i figured if it was
something sufficiently simple, it would be useful.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-02-07 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 15:57 Robert P. J. Day
2012-02-07  9:33 ` Sascha Hauer
2012-02-07 11:13   ` Robert P. J. Day [this message]
2012-02-07 11:56     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1202070608280.17306@oneiric \
    --to=rpjday@crashcourse.ca \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox