mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Kurz <akurz@blala.de>
To: "Andrey Smirnov <andrew.smirnov@gmail.com>"@blala.de
Cc: barebox@lists.infradead.org
Subject: re: [RESEND v3 50/52] scripts: imx-image: Share the code to write barebox header
Date: Mon, 11 Jun 2018 06:39:32 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.20.1806110631180.5797@blala.de> (raw)

Hi Andrey,
there's something wrong with this patch,
when generating e.g. the kindle3 image (imx35 / kindle3_defconfig) 
with this patch, the generated imximage differs and the device wont
boot. "Share the code to ..." should not change the program behaviour.

Regards, Alexander

--- barebox.imximg_x4_1 2018-06-11 08:27:31.660011787 +0200
+++ barebox.imximg_x4_2 2018-06-11 08:27:26.676011669 +0200
@@ -1,6 +1,6 @@
 000000 ea0003fe eafffffe eafffffe eafffffe
 000010 eafffffe eafffffe eafffffe eafffffe
-000020 65726162 00786f62 00000000 00022000
+000020 65726162 00786f62 00000000 00000000
 000030 55555555 55555555 55555555 55555555
 *
 000050 00000000 00000000 00000000 00000000
@@ -25,12 +25,8 @@
 000510 00000000 00022000 00000000 00000000
 000520 00000000 00000000 00000000 00000000
 *
-001000 ea0003fe eafffffe eafffffe eafffffe
-001010 eafffffe eafffffe eafffffe eafffffe
-001020 65726162 00786f62 00000000 00022000
-001030 55555555 55555555 55555555 55555555
-*
-001050 00000000 00000000 00000000 00000000
+001020 00000000 00000000 00000000 00022000
+001030 00000000 00000000 00000000 00000000
 *
 001400 87f00400 000000b1 00000000 87eff814
 001410 00000000 87eff81c 87eff400 b17219e9


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-06-11  6:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  6:39 Alexander Kurz [this message]
2018-06-11  6:55 ` Sascha Hauer
2018-06-11 17:40 ` Andrey Smirnov
  -- strict thread matches above, loose matches on Subject: below --
2018-06-07 13:00 [RESEND v3 00/52] ARM: i.MX8MQ and EVK support Andrey Smirnov
2018-06-07 13:01 ` [RESEND v3 50/52] scripts: imx-image: Share the code to write barebox header Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1806110631180.5797@blala.de \
    --to=akurz@blala.de \
    --cc="Andrey Smirnov <andrew.smirnov@gmail.com>"@blala.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox