From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: can barebox avoid creating typedefs just for struct shortcuts?
Date: Mon, 21 Dec 2009 04:22:43 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0912210419020.6190@localhost> (raw)
i noticed the following:
$ grep -rw gd_t *
arch/arm/include/asm/global_data.h:typedef struct global_data gd_t;
arch/ppc/include/asm/global_data.h: * Keep it *SMALL* and remember to set CFG_GBL_DATA_SIZE > sizeof(gd_t)
arch/ppc/include/asm/global_data.h:} gd_t;
arch/sandbox/include/asm/global_data.h:typedef struct global_data gd_t;
$
it's obvious that the typedef "gd_t" is being created as a
time-saving shortcut. that approach has been actively discouraged in
the main kernel tree for quite some time, as it just obfuscates the
code. there are, of course, numerous typedefs being used to support
legitimately opaque types, but creating more of them just to save
keystrokes is now frowned upon.
and since it looks like no one is actually using that one yet, does
anyone mind if i remove it?
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2009-12-21 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 9:22 Robert P. J. Day [this message]
2009-12-21 10:04 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912210419020.6190@localhost \
--to=rpjday@crashcourse.ca \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox