[PATCH] Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".

[PATCH] Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".

[Robert P. J. Day]

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  while this fixes an obvious typo in this file, it's really just a
band-aid since this header file sets *numerous* CONFIG_-prefixed
macros, which it shouldn't be doing.  any macros prefixed with CONFIG_
should be reserved for the Kconfig namespace, so it wouldn't hurt to
apply this patch, but it's clear that this file needs a lot more work
at some point in the future.


diff --git a/board/eco920/config.h b/board/eco920/config.h
index 3fb8beb..6f8f8ea 100644
--- a/board/eco920/config.h
+++ b/board/eco920/config.h
@@ -112,7 +112,7 @@

 #define CFG_BAUDRATE_TABLE	{115200 , 19200, 38400, 57600, 9600 }

-#define	CFG_LONGHELP				/* undef to save memory		*/
+#define	CONFIG_LONGHELP				/* undef to save memory		*/
 #define CFG_PROMPT		"barebox> "	/* Monitor Command Prompt */
 #define CFG_CBSIZE		1024		/* Console I/O Buffer Size */
 #define CFG_MAXARGS		32		/* max number of command args */

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".

[Sascha Hauer]

Hi Robert,

On Tue, Dec 22, 2009 at 09:51:19AM -0500, Robert P. J. Day wrote:
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   while this fixes an obvious typo in this file, it's really just a
> band-aid since this header file sets *numerous* CONFIG_-prefixed
> macros, which it shouldn't be doing.  any macros prefixed with CONFIG_
> should be reserved for the Kconfig namespace, so it wouldn't hurt to
> apply this patch, but it's clear that this file needs a lot more work
> at some point in the future.

I used the eco920 during early development. We maybe have the
opportunity to work on this board in the next time and then I'll fix
this. Otherwise I tend to remove the board completely.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".

[Robert P. J. Day]

On Wed, 23 Dec 2009, Sascha Hauer wrote:

> Hi Robert,
>
> On Tue, Dec 22, 2009 at 09:51:19AM -0500, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> >   while this fixes an obvious typo in this file, it's really just
> > a band-aid since this header file sets *numerous* CONFIG_-prefixed
> > macros, which it shouldn't be doing.  any macros prefixed with
> > CONFIG_ should be reserved for the Kconfig namespace, so it
> > wouldn't hurt to apply this patch, but it's clear that this file
> > needs a lot more work at some point in the future.
>
> I used the eco920 during early development. We maybe have the
> opportunity to work on this board in the next time and then I'll fix
> this. Otherwise I tend to remove the board completely.

  no problem.  don't think you need to explain dropping any patch
submissions from me -- obviously, i don't know the history of the
software.  whatever you decide.

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox