From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 25 May 2021 10:57:06 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1llSs6-00007B-4s for lore@lore.pengutronix.de; Tue, 25 May 2021 10:57:06 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llSs4-0007cS-TK for lore@pengutronix.de; Tue, 25 May 2021 10:57:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:From:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Fcbg5VkT/zu+FhB4NiGNImy61HMUfLeBNROeVQd4Z98=; b=WzyfuLQhzHXbFar4GDg0ejSTuY NkVdOEzRH4USIaW4fUepxEr57UKh9cBb47v7Ps725hTUd1tcgci/dGzx357HHwOlB9hhhFqQ/GnuV UxyJbnctZ5YU0NLTcDu1NlRcGKxMtgCejTwMYOMDB2s8fk7GBS+PgHJIXH/gBt/qfl/aLCIFxhq9e jOsVbDU7TEFSHEcT6RFJreAW49bRwSPAIxjWyvKf/G8+mbkcmD12PP2RHW1lxp7AmpdgY/LxDLMzC CoTml/iZiFG5CxjW3ZXLLam1N5jYYzJZ0v/prp5zUx6Uc8AWlTRvliDjFEwtDcMabX8eJOeB8B7cz 8Uu9iQxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llSqm-004D0d-RN; Tue, 25 May 2021 08:55:45 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llSpq-004Cdx-Dg for barebox@lists.infradead.org; Tue, 25 May 2021 08:54:48 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1llSpp-0006z1-2U; Tue, 25 May 2021 10:54:45 +0200 From: Bastian Krause To: Lucas Stach , Sascha Hauer Cc: Barebox List References: <20210415131617.3582-2-s.hauer@pengutronix.de> <20210415140313.29161-1-s.hauer@pengutronix.de> <20210415151231.GI19819@pengutronix.de> <1e17f965a5a60aaba5b092785eb815dd7c4d83a0.camel@pengutronix.de> <213a717d-a80d-e140-6a14-06ae7308292f@pengutronix.de> Message-ID: Date: Tue, 25 May 2021 10:54:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <213a717d-a80d-e140-6a14-06ae7308292f@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_015446_545921_6361DE79 X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] ARM: i.MX: sabresd: Add support for i.MX6QP board variant X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 4/22/21 5:14 PM, Bastian Krause wrote: > On 4/15/21 5:31 PM, Lucas Stach wrote: >> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer: >>> On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote: >>>> Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer: >>>>> The SabreSD comes with different SoC variants. This patch adds support >>>>> for the i.MX6QP based board. the DCD data has been taken from U-Boot >>>>> 2021.04 >>>>> >>>>> Signed-off-by: Sascha Hauer >>>>> --- >>>>> >>>> [...] >>>>> new file mode 100644 >>>>> index 0000000000..52cc8aa73b >>>>> --- /dev/null >>>>> +++ b/arch/arm/dts/imx6qp-sabresd.dts >>>>> @@ -0,0 +1,42 @@ >>>>> +/* >>>>> + * Copyright 2012 Freescale Semiconductor, Inc. >>>>> + * Copyright 2011 Linaro Ltd. >>>>> + * >>>>> + * The code contained herein is licensed under the GNU General Public >>>>> + * License. You may obtain a copy of the GNU General Public License >>>>> + * Version 2 or later at the following locations: >>>>> + * >>>>> + * http://www.opensource.org/licenses/gpl-license.html >>>>> + * http://www.gnu.org/copyleft/gpl.html >>>>> + */ >>>>> + >>>>> +#include >>>>> + >>>>> +/ { >>>>> + model = "Freescale i.MX6 Quad SABRE Smart Device Board"; >>>>> + compatible = "fsl,imx6q-sabresd", "fsl,imx6q"; >>>> >>>> I'm not sure I like this overwriting of the compatible string. AFAICS >>>> we don't have any instances for "fsl,imx6qp" compatible checks in >>>> either Barebox or Linux kernel, so it shouldn't cause any immediate >>>> damage, but this still feels wrong. >>> >>> It's overwritten with the same strings as the included upstream dts has. >>> Anyway, as you say overwriting them here seems wrong. I removed it. >> >> You had me confused for bit here, so I just checked and the compatible >> in the included upstream dts is different, as expected: >> >> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp"; >> >> So now that you removed those lines, does you board file need fixing >> for the different compatibles? > > My board works fine (bootspec-wise) with the dropped compatible. What's the state of this patch, Sascha? Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox